Issue 4841051: Reuse one Firefox process for all browser test cases.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4841051: Reuse one Firefox process for all browser test cases. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by kpreid2

Modified:
14 years, 8 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Makes the WebDriver instance used by BrowserTestCase static, and adds a small wrapper to create a new window for each individual test case. The existing behavior (leave failing tests' windows open, close all others) is preserved, but with fewer processes.

Patch Set 1 #

Patch Set 2 : Reuse one Firefox process for all browser test cases. #

Total comments: 1

Patch Set 3 : Reuse one Firefox process for all browser test cases. #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -6 lines)			Patch
	M	tests/com/google/caja/plugin/BrowserTestCase.java	View	1 2	3 chunks	+74 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ihab.awad

lgtm http://codereview.appspot.com/4841051/diff/3001/tests/com/google/caja/plugin/BrowserTestCase.java File tests/com/google/caja/plugin/BrowserTestCase.java (right): http://codereview.appspot.com/4841051/diff/3001/tests/com/google/caja/plugin/BrowserTestCase.java#newcode292 tests/com/google/caja/plugin/BrowserTestCase.java:292: * It lazily creates the actual WebDriver upon ...

14 years, 8 months ago (2011-08-05 01:42:29 UTC) #2

lgtm

Expand All Messages | Collapse All Messages