Adding support for gContact:status bit and samples for Profiles API, fixing bugs in ContactsClient.

+vicfryzel
+afshar
+ccherubino

[alainv, 2011-08-10 20:52:33]

On 2011/08/03 23:57:42, alainv wrote:

Ping?

[alainv, 2011-08-15 15:56:05]

On 2011/08/10 20:52:33, alainv wrote:
> On 2011/08/03 23:57:42, alainv wrote:
> 
> Ping?

Anyone?

[Claudio Cherubino, 2011-08-15 16:16:13]

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
File samples/contacts/unshare_profiles.py (right):

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
samples/contacts/unshare_profiles.py:1: #!/usr/bin/env python
using #!/usr/bin/python2.4 is no more required, but in Goobuntu we tend to use
#!/usr/bin/python so I'd stick with that instead (check the other files too).
For reference:

https://wiki.corp.google.com/twiki/bin/view/Main/PythonShebangLines

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
samples/contacts/unshare_profiles.py:28: import gdata.contacts.data
are the imports correctly ordered?

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
samples/contacts/unshare_profiles.py:36: error: Number of failed operations.
I'd use something like 'error_count' or 'num_errors' or 'errors' instead, it is
not clear that 'error' stores the count

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
samples/contacts/unshare_profiles.py:73: if None:
what is this checking?

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
samples/contacts/unshare_profiles.py:119: """Demonstrates use of the Profiles
using the ProfilesManager object."""
this app actually demonstrates the use of the Profiles API to unshare profiles,
please correct the comment

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
samples/contacts/unshare_profiles.py:134: entry.batch_status.code,
check indentation

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/client.py
File src/gdata/contacts/client.py (right):

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/client.py#...
src/gdata/contacts/client.py:288: ifmatch_header=ifmatch_header, **kwargs)
what is this aligned with?

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/client.py#...
src/gdata/contacts/client.py:322: contact_entry_or_url: a
gdata.contacts.ContactEntry objecr or a string
s/objecr/object

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/client.py#...
src/gdata/contacts/client.py:329: # No etag means no photo has been assigned to
this contact.
should this comment be moved to the else branch?

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/client.py#...
src/gdata/contacts/client.py:338: ifmatch_header=ifmatch_header, **kwargs)
check alignment here

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/data.py
File src/gdata/contacts/data.py (right):

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/data.py#ne...
src/gdata/contacts/data.py:374: initals = Initials
this is not related to this patch, but the initals property is mispelled

[alainv, 2011-08-15 16:30:23]

Thanks for reviewing this patch!

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
File samples/contacts/unshare_profiles.py (right):

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
samples/contacts/unshare_profiles.py:28: import gdata.contacts.data
On 2011/08/15 16:16:13, Claudio Cherubino wrote:
> are the imports correctly ordered?

Done.

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
samples/contacts/unshare_profiles.py:36: error: Number of failed operations.
On 2011/08/15 16:16:13, Claudio Cherubino wrote:
> I'd use something like 'error_count' or 'num_errors' or 'errors' instead, it
is
> not clear that 'error' stores the count

Done.

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
samples/contacts/unshare_profiles.py:73: if None:
On 2011/08/15 16:16:13, Claudio Cherubino wrote:
> what is this checking?

Hum... my mistake :-/

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
samples/contacts/unshare_profiles.py:119: """Demonstrates use of the Profiles
using the ProfilesManager object."""
On 2011/08/15 16:16:13, Claudio Cherubino wrote:
> this app actually demonstrates the use of the Profiles API to unshare
profiles,
> please correct the comment

Done.

http://codereview.appspot.com/4832050/diff/2003/samples/contacts/unshare_prof...
samples/contacts/unshare_profiles.py:134: entry.batch_status.code,
On 2011/08/15 16:16:13, Claudio Cherubino wrote:
> check indentation

Done.

[alainv, 2011-08-15 16:40:09]

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/client.py
File src/gdata/contacts/client.py (right):

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/client.py#...
src/gdata/contacts/client.py:322: contact_entry_or_url: a
gdata.contacts.ContactEntry objecr or a string
On 2011/08/15 16:16:13, Claudio Cherubino wrote:
> s/objecr/object

Done.

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/client.py#...
src/gdata/contacts/client.py:329: # No etag means no photo has been assigned to
this contact.
On 2011/08/15 16:16:13, Claudio Cherubino wrote:
> should this comment be moved to the else branch?

Done.

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/data.py
File src/gdata/contacts/data.py (right):

http://codereview.appspot.com/4832050/diff/2003/src/gdata/contacts/data.py#ne...
src/gdata/contacts/data.py:374: initals = Initials
On 2011/08/15 16:16:13, Claudio Cherubino wrote:
> this is not related to this patch, but the initals property is mispelled

Done.

[Claudio Cherubino, 2011-08-15 16:41:40]

LGTM