Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(221)

Issue 48310043: code review 48310043: os/fsnotify: API sketch

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by rsc
Modified:
3 years, 6 months ago
Visibility:
Public.

Description

os/fsnotify: API sketch This CL is the first draft of the API for the new os/fsnotify package. It is based on http://godoc.org/github.com/howeyc/fsnotify. Once the API is settled, we'll implement it everywhere.

Patch Set 1 #

Patch Set 2 : diff -r 1b7c5daffdff https://code.google.com/p/go/ #

Total comments: 4

Patch Set 3 : diff -r 1b7c5daffdff https://code.google.com/p/go/ #

Total comments: 23
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
A src/pkg/os/fsnotify/event.go View 1 1 chunk +68 lines, -0 lines 23 comments Download

Messages

Total messages: 27
rsc
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
3 years, 8 months ago (2014-01-07 01:24:32 UTC) #1
cespare
On 2014/01/07 01:24:32, rsc wrote: > Hello mailto:golang-codereviews@googlegroups.com, (cc: mailto:cespare@gmail.com), > > I'd like you ...
3 years, 8 months ago (2014-01-07 01:28:20 UTC) #2
dsymonds
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode44 src/pkg/os/fsnotify/event.go:44: Event <-chan Event It feels odd to name a ...
3 years, 8 months ago (2014-01-07 01:30:36 UTC) #3
minux1
https://codereview.appspot.com/48310043/diff/20001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/20001/src/pkg/os/fsnotify/event.go#newcode11 src/pkg/os/fsnotify/event.go:11: // TODO: What is the Windows equivalent? Where can ...
3 years, 8 months ago (2014-01-07 01:43:35 UTC) #4
brainman
On 2014/01/07 01:43:35, minux wrote: > https://codereview.appspot.com/48310043/diff/20001/src/pkg/os/fsnotify/event.go > File src/pkg/os/fsnotify/event.go (right): > > https://codereview.appspot.com/48310043/diff/20001/src/pkg/os/fsnotify/event.go#newcode11 > ...
3 years, 8 months ago (2014-01-07 02:09:58 UTC) #5
brainman
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode11 src/pkg/os/fsnotify/event.go:11: // TODO: What is the Windows equivalent? Where can ...
3 years, 8 months ago (2014-01-07 02:32:43 UTC) #6
dfc
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode39 src/pkg/os/fsnotify/event.go:39: File string What about adding Extra string For Op ...
3 years, 8 months ago (2014-01-07 02:44:03 UTC) #7
iant
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode11 src/pkg/os/fsnotify/event.go:11: // TODO: What is the Windows equivalent? Where can ...
3 years, 8 months ago (2014-01-07 04:06:37 UTC) #8
nathany
Looking at the API so far, it is oriented around files. Inotify is able to ...
3 years, 8 months ago (2014-01-07 04:42:07 UTC) #9
rsc
On Mon, Jan 6, 2014 at 11:42 PM, <nj@nathany.com> wrote: > Looking at the API ...
3 years, 8 months ago (2014-01-07 04:49:51 UTC) #10
cespare
I too have found myself implementing recursive watches (and also rate limiting/throttling) every time I ...
3 years, 8 months ago (2014-01-07 04:51:50 UTC) #11
minux1
On Mon, Jan 6, 2014 at 11:49 PM, Russ Cox <rsc@golang.org> wrote: > On Mon, ...
3 years, 8 months ago (2014-01-07 05:13:32 UTC) #12
cespare
Does Linux have recursive watch support? I haven't been able to find it if so. ...
3 years, 8 months ago (2014-01-07 05:18:11 UTC) #13
nathany
On 2014/01/07 04:49:51, rsc wrote: > On Mon, Jan 6, 2014 at 11:42 PM, <mailto:nj@nathany.com> ...
3 years, 8 months ago (2014-01-07 05:23:27 UTC) #14
nathany
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode19 src/pkg/os/fsnotify/event.go:19: const ( The name I came up with is ...
3 years, 8 months ago (2014-01-07 05:32:30 UTC) #15
minux1
On Tue, Jan 7, 2014 at 12:17 AM, Caleb Spare <cespare@gmail.com> wrote: > Does Linux ...
3 years, 8 months ago (2014-01-07 05:33:16 UTC) #16
minux1
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode20 src/pkg/os/fsnotify/event.go:20: Create Op = 1 << iota how about adding ...
3 years, 8 months ago (2014-01-07 05:34:33 UTC) #17
nathany
On 2014/01/07 05:33:16, minux wrote: > To implement race-free user-space recursive watches, one need os/fsnotify ...
3 years, 8 months ago (2014-01-07 05:45:28 UTC) #18
chressie1
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode63 src/pkg/os/fsnotify/event.go:63: // The file must have been previously added with ...
3 years, 8 months ago (2014-01-07 09:21:14 UTC) #19
rog
Even if all platforms do not natively support recursive watching, I think it would be ...
3 years, 8 months ago (2014-01-07 12:27:26 UTC) #20
howeyc
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode44 src/pkg/os/fsnotify/event.go:44: Event <-chan Event What is the plan to handle ...
3 years, 8 months ago (2014-01-07 14:24:12 UTC) #21
aram
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode48 src/pkg/os/fsnotify/event.go:48: func NewWatcher() *Watcher On 2014/01/07 02:44:04, dfc wrote: > ...
3 years, 8 months ago (2014-01-07 14:43:50 UTC) #22
r
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode5 src/pkg/os/fsnotify/event.go:5: package fsnotify // Package fsnotify does something. https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode18 src/pkg/os/fsnotify/event.go:18: ...
3 years, 8 months ago (2014-01-07 17:51:12 UTC) #23
kevlar
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode20 src/pkg/os/fsnotify/event.go:20: Create Op = 1 << iota On 2014/01/07 05:34:34, ...
3 years, 8 months ago (2014-01-07 22:06:37 UTC) #24
nathany
> I second the request for recursive watch. It's tricky enough and common enough > ...
3 years, 8 months ago (2014-01-11 06:42:36 UTC) #25
nathany
https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go File src/pkg/os/fsnotify/event.go (right): https://codereview.appspot.com/48310043/diff/40001/src/pkg/os/fsnotify/event.go#newcode60 src/pkg/os/fsnotify/event.go:60: func (w *Watcher) Add(file string, op Op) error On ...
3 years, 7 months ago (2014-02-02 04:21:08 UTC) #26
rsc
3 years, 6 months ago (2014-03-03 18:16:56 UTC) #27
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted