code review 48300043: net/http: use TCP keep-alives by default

net/http: use TCP keep-alives for ListenAndServe and ListenAndServeTLS

Our default behavior for the common cases shouldn't lead to
leaked TCP connections (e.g. from people closing laptops) when
their Go servers are exposed to the open Internet without a
proxy in front.

Too many users on golang-nuts have learned this the hard way.

No API change. Only ListenAndServe and ListenAndServeTLS are
updated.

[bradfitz, 2014-01-07 01:07:52]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2014-01-09 19:34:00]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[cespare, 2014-01-09 20:18:06]

On 2014/01/09 19:34:00, bradfitz wrote:
> Hello mailto:golang-codereviews@googlegroups.com (cc:
> mailto:golang-codereviews@googlegroups.com),
> 
> Please take another look.

LGTM

[gobot, 2014-01-09 21:18:13]

R=rsc@golang.org (assigned by bradfitz@golang.org)

[minux1, 2014-01-09 23:03:33]

LGTM.

Please update the subject to be more specific, e.g.
net/http: use TCP keep-alives for ListenAndServe and ListenAndServeTLS.

[bradfitz, 2014-01-09 23:05:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=e4b3e3c1edda ***

net/http: use TCP keep-alives for ListenAndServe and ListenAndServeTLS

Our default behavior for the common cases shouldn't lead to
leaked TCP connections (e.g. from people closing laptops) when
their Go servers are exposed to the open Internet without a
proxy in front.

Too many users on golang-nuts have learned this the hard way.

No API change. Only ListenAndServe and ListenAndServeTLS are
updated.

R=golang-codereviews, cespare, gobot, rsc, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/48300043