Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1882)

Issue 4820048: Adds epsilon to Bezier range calculations.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by MikeSol
Modified:
7 years, 3 months ago
Reviewers:
pkx166h, mike, dak, hanwenn, Keith
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds epsilon to Bezier range calculations.

Patch Set 1 #

Patch Set 2 : Regtest added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
A input/regression/bezier-rounding-error.ly View 1 1 chunk +11 lines, -0 lines 0 comments Download
M lily/bezier.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8
MikeSol
This passes regtests and adds a regtest to show it in action. As I know ...
7 years, 11 months ago (2011-07-27 08:37:06 UTC) #1
pkx166h
On 2011/07/27 08:37:06, MikeSol wrote: > This passes regtests It does indeed :) James
7 years, 11 months ago (2011-07-27 20:01:29 UTC) #2
pkx166h
Added as http://code.google.com/p/lilypond/issues/detail?id=1784 Just in case (some people use tracker more than Rietveld or their ...
7 years, 11 months ago (2011-07-27 20:04:52 UTC) #3
hanwenn
this just moves the rounding error an epsilon away. can you post an image of ...
7 years, 11 months ago (2011-07-27 20:59:42 UTC) #4
mike_apollinemike.com
On Jul 27, 2011, at 10:59 PM, hanwenn@gmail.com wrote: > this just moves the rounding ...
7 years, 11 months ago (2011-07-27 21:09:35 UTC) #5
hanwenn
That's weird - the overlap looks way more than 1e-10. Are you sure it is ...
7 years, 11 months ago (2011-07-27 21:42:29 UTC) #6
Keith
Mike, this could make sense *if* it is normal to ask where the Bezier curve ...
7 years, 8 months ago (2011-10-01 06:02:54 UTC) #7
dak
7 years, 3 months ago (2012-03-12 23:13:39 UTC) #8
On 2011/10/01 06:02:54, Keith wrote:
> Mike, this could make sense *if* it is normal to ask where the Bezier curve
> touches the left or right side of its bounding box.

A Bezier curve stays within the convex hull formed by the end points and the
control points.  If the x (or y) coordinates of the control points are within
the interval of the end points, the end points determine the x (or y) coordinate
of the bounding box.  No need to calculate anything else in that case.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b