Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1764)

Issue 4816044: Fix 1214: cueDuring and quoteDuring should also quote voices that create subvoices (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by Reinhold
Modified:
7 years, 10 months ago
Reviewers:
pkx166h, Keith, Neil Puttock, reinhold
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix 1214: cueDuring and quoteDuring should also quote voices that create subvoices If a voice was quoted that created a subvoice, add-quotable wrongly selected only that subvoice for quoting rather than the original voice. The proper fix is to correctly use the assoc list returned by recording-group-emulate. We need to hand it a proper unique voice name and can then extract the events for just this voice, no matter which other voices are created.

Patch Set 1 #

Patch Set 2 : Fix quoting if argument to addQuote is already a voice #

Total comments: 2

Patch Set 3 : Better warnings (include source location), don't crash if quoted music is empty #

Patch Set 4 : Fix quoting in all cases of subvoices #

Total comments: 12

Patch Set 5 : Fix indentation, update doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -11 lines) Patch
M Documentation/notation/staff.itely View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
A input/regression/quote-during-subvoice.ly View 1 2 3 4 1 chunk +68 lines, -0 lines 0 comments Download
M scm/music-functions.scm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scm/part-combiner.scm View 1 2 3 4 1 chunk +24 lines, -7 lines 0 comments Download

Messages

Total messages: 9
pkx166h
Make works but fails on reg test check. ---snip-- Processing `/home/jlowe/lilypond-git/build/out/lybook-testdb/aa/lily-c55a6eaf.ly' Parsing... Renaming input to: ...
7 years, 11 months ago (2011-07-22 19:52:11 UTC) #1
pkx166h
make passes and reg test check is ok.
7 years, 11 months ago (2011-07-24 09:57:44 UTC) #2
Keith
I like it, although I can still get the error if I put a new ...
7 years, 11 months ago (2011-07-26 02:17:28 UTC) #3
Reinhold
On 2011/07/26 02:17:28, Keith wrote: > I like it, although I can still get the ...
7 years, 11 months ago (2011-07-28 12:46:17 UTC) #4
Keith
On Thu, 28 Jul 2011 05:46:29 -0700, <reinhold.kainhofer@gmail.com> wrote: > Message: > On 2011/07/26 02:17:28, ...
7 years, 11 months ago (2011-07-29 04:39:27 UTC) #5
reinhold_kainhofer.com
Am Freitag 29 Juli 2011, 06:38:49 schrieb Keith OHara: > On Thu, 28 Jul 2011 ...
7 years, 11 months ago (2011-07-29 09:09:35 UTC) #6
Reinhold
On 2011/07/29 04:39:27, Keith wrote: > On Thu, 28 Jul 2011 05:46:29 -0700, <mailto:reinhold.kainhofer@gmail.com> wrote: ...
7 years, 10 months ago (2011-08-10 14:08:50 UTC) #7
Neil Puttock
LGTM. http://codereview.appspot.com/4816044/diff/15001/input/regression/quote-during-subvoice.ly File input/regression/quote-during-subvoice.ly (right): http://codereview.appspot.com/4816044/diff/15001/input/regression/quote-during-subvoice.ly#newcode1 input/regression/quote-during-subvoice.ly:1: \version "2.15.6" 2.15.9 http://codereview.appspot.com/4816044/diff/15001/input/regression/quote-during-subvoice.ly#newcode18 input/regression/quote-during-subvoice.ly:18: \addQuote quoteMe \quoteMe ...
7 years, 10 months ago (2011-08-10 17:28:48 UTC) #8
Reinhold
7 years, 10 months ago (2011-08-13 10:39:51 UTC) #9
Pushed with commit 1b11dc0cb1bec0e353773aac6b8afba9030f88c4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b