Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1750)

Issue 4811066: Rewrite regtest mozart-hrn-3.ly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by PhilEHolmes
Modified:
7 years, 10 months ago
Reviewers:
james.lowe, Graham Percival (old account), Neil Puttock, mail, Graham Percival, email
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

This regtest had a number of old lines of syntax and produces warnings with the latest version of LilyPond. It also uses tabs for indents. This is a cleaner, warning-free version.

Patch Set 1 #

Total comments: 39

Patch Set 2 : Version 2 of the updated mozart horn regtest #

Patch Set 3 : Final changes to mozart horn regtest #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -536 lines) Patch
M input/regression/mozart-hrn-3.ly View 1 2 2 chunks +58 lines, -47 lines 1 comment Download
M input/regression/mozart-hrn3-allegro.ily View 1 chunk +153 lines, -193 lines 0 comments Download
M input/regression/mozart-hrn3-defs.ily View 1 1 chunk +16 lines, -33 lines 0 comments Download
M input/regression/mozart-hrn3-romanze.ily View 1 chunk +72 lines, -81 lines 0 comments Download
M input/regression/mozart-hrn3-rondo.ily View 1 1 chunk +162 lines, -182 lines 0 comments Download

Messages

Total messages: 20
PhilEHolmes
Please review.
7 years, 10 months ago (2011-08-02 17:26:12 UTC) #1
Graham Percival (old account)
LGTM, although I initially misread the commit message as saying that the *new* version uses ...
7 years, 10 months ago (2011-08-02 19:26:37 UTC) #2
Neil Puttock
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly File input/regression/mozart-hrn-3.ly (right): http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode25 input/regression/mozart-hrn-3.ly:25: \fill-line { "This music is part of the Mutopia ...
7 years, 10 months ago (2011-08-02 19:59:39 UTC) #3
PhilEHolmes
Again - not too familiar with the codereview tool, so I hope this makes sense. ...
7 years, 10 months ago (2011-08-06 14:57:14 UTC) #4
mail_philholmes.net
----- Original Message ----- From: <PhilEHolmes@googlemail.com> To: <percival.music.ca@gmail.com>; <n.puttock@gmail.com> Cc: <reply@codereview.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Saturday, August ...
7 years, 10 months ago (2011-08-06 15:00:35 UTC) #5
Neil Puttock
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly File input/regression/mozart-hrn-3.ly (right): http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode25 input/regression/mozart-hrn-3.ly:25: \fill-line { "This music is part of the Mutopia ...
7 years, 10 months ago (2011-08-06 15:23:34 UTC) #6
email_philholmes.net
----- Original Message ----- From: <n.puttock@gmail.com> To: <PhilEHolmes@googlemail.com>; <percival.music.ca@gmail.com>; <mail@philholmes.net> Cc: <lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com> Sent: Saturday, ...
7 years, 10 months ago (2011-08-06 16:00:05 UTC) #7
Graham Percival (old account)
LGTM. My comment is a tiny nitpick; I don't think it needs to hold up ...
7 years, 10 months ago (2011-08-07 22:42:47 UTC) #8
email_philholmes.net
----- Original Message ----- From: <percival.music.ca@gmail.com> To: <PhilEHolmes@googlemail.com>; <n.puttock@gmail.com>; <mail@philholmes.net>; <email@philholmes.net> Cc: <lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com> Sent: ...
7 years, 10 months ago (2011-08-08 14:54:21 UTC) #9
James.Lowe_datacore.com
I'll push it. james )-----Original Message----- )From: lilypond-devel-bounces+james.lowe=datacore.com@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore.com@gnu.org] On )Behalf Of Phil Holmes )Sent: ...
7 years, 10 months ago (2011-08-08 15:13:24 UTC) #10
James.Lowe_datacore.com
commit 403e66a45e752231fb49deea2e8ccb1976505c7c Thanks Mr Holmes! James )-----Original Message----- )From: lilypond-devel-bounces+james.lowe=datacore.com@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore.com@gnu.org] On )Behalf Of James ...
7 years, 10 months ago (2011-08-08 15:40:40 UTC) #11
mail_philholmes.net
Woh. There's an error - \url isn't part of Lilypond syntax! I'd corrected this to ...
7 years, 10 months ago (2011-08-08 15:46:01 UTC) #12
James.Lowe_datacore.com
no problem. I'll do it now. James )-----Original Message----- )From: Phil Holmes [mailto:mail@philholmes.net] )Sent: 08 ...
7 years, 10 months ago (2011-08-08 15:52:13 UTC) #13
James.Lowe_datacore.com
Phil, ________________________________________ From: Phil Holmes [mail@philholmes.net] Sent: 08 August 2011 16:45 To: James Lowe; PhilEHolmes@googlemail.com; ...
7 years, 10 months ago (2011-08-08 15:58:42 UTC) #14
Graham Percival
On Mon, Aug 08, 2011 at 04:45:49PM +0100, Phil Holmes wrote: > > Woh. There's ...
7 years, 10 months ago (2011-08-08 15:59:46 UTC) #15
email_philholmes.net
----- Original Message ----- From: "James Lowe" <James.Lowe@datacore.com> To: "Phil Holmes" <mail@philholmes.net>; <PhilEHolmes@googlemail.com>; <percival.music.ca@gmail.com>; <n.puttock@gmail.com>; ...
7 years, 10 months ago (2011-08-08 16:02:42 UTC) #16
James.Lowe_datacore.com
Second time's the charm ;) commit 6f818c30809d32c10b33d13e51f0910788ac0493 James )-----Original Message----- )From: Phil Holmes [mailto:phileholmes@googlemail.com] On ...
7 years, 10 months ago (2011-08-08 16:08:26 UTC) #17
Graham Percival
Since you pushed it, James, could you correct the \typewriter to \with-url ? Before you ...
7 years, 10 months ago (2011-08-08 21:33:02 UTC) #18
email_philholmes.net
----- Original Message ----- From: "Graham Percival" <graham@percival-music.ca> To: "James Lowe" <James.Lowe@datacore.com> Cc: "Phil Holmes" ...
7 years, 10 months ago (2011-08-09 08:47:34 UTC) #19
Neil Puttock
7 years, 10 months ago (2011-08-09 19:59:38 UTC) #20
On 9 August 2011 09:47, Phil Holmes <email@philholmes.net> wrote:

> I said in a separate message that this isn't necessary.  The link is
> automatically converted to a clickable link.

This only works reliably with Adobe Reader.

Foxit produces an incorrect link: mutopia.org/It (it picks up the
start of the next line)

Neither okular nor evince produces a link.

Cheers,
Neil
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b