Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6416)

Issue 4810080: Advanced Touch API - Flick using WebView

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by juantrujillo
Modified:
12 years, 8 months ago
Reviewers:
Eran, berrada
CC:
webdriver-eng_google.com
Base URL:
http://selenium.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Advanced Touch API - Flick using WebView #

Patch Set 3 : Advanced Touch API - Flick using WebView #

Patch Set 4 : Flick using View #

Patch Set 5 : Flick using WebView #

Patch Set 6 : Flick with WebView #

Patch Set 7 : Flick using array for speeds #

Patch Set 8 : Flick using long page #

Patch Set 9 : Flick reusing long page content #

Patch Set 10 : Added WebDriverWebView fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -15 lines) Patch
M android/src/java/org/openqa/selenium/android/ActivityController.java View 1 2 3 4 1 chunk +23 lines, -1 line 0 comments Download
M android/src/java/org/openqa/selenium/android/AndroidTouchScreen.java View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M android/src/java/org/openqa/selenium/android/app/MainActivity.java View 1 2 3 4 5 6 3 chunks +12 lines, -1 line 0 comments Download
M android/src/java/org/openqa/selenium/android/app/WebDriverWebView.java View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -3 lines 0 comments Download
A + common/src/web/longContentPage.html View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -5 lines 0 comments Download
M java/client/src/org/openqa/selenium/TouchScreen.java View 1 2 3 4 5 2 chunks +10 lines, -2 lines 0 comments Download
A java/client/src/org/openqa/selenium/interactions/touch/FlickAction.java View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
M java/client/src/org/openqa/selenium/interactions/touch/TouchActions.java View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M java/client/src/org/openqa/selenium/remote/DriverCommand.java View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M java/client/src/org/openqa/selenium/remote/HttpCommandExecutor.java View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M java/client/src/org/openqa/selenium/remote/RemoteTouchScreen.java View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M java/client/src/org/openqa/selenium/support/events/internal/EventFiringTouch.java View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M java/client/test/org/openqa/selenium/Pages.java View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
A java/client/test/org/openqa/selenium/TouchFlickTest.java View 1 2 3 4 5 6 7 8 1 chunk +49 lines, -0 lines 0 comments Download
M java/server/src/org/openqa/selenium/remote/server/DriverServlet.java View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
A java/server/src/org/openqa/selenium/remote/server/handler/interactions/touch/Flick.java View 1 2 3 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 12
juantrujillo
12 years, 8 months ago (2011-08-07 23:06:07 UTC) #1
juantrujillo
12 years, 8 months ago (2011-08-17 17:10:30 UTC) #2
juantrujillo
12 years, 8 months ago (2011-08-17 18:16:27 UTC) #3
juantrujillo
12 years, 8 months ago (2011-08-19 02:55:50 UTC) #4
berrada
LGTM
12 years, 8 months ago (2011-08-19 04:04:18 UTC) #5
juantrujillo
12 years, 8 months ago (2011-08-19 18:01:03 UTC) #6
juantrujillo
12 years, 8 months ago (2011-08-19 18:08:57 UTC) #7
juantrujillo
12 years, 8 months ago (2011-08-19 18:16:11 UTC) #8
juantrujillo
12 years, 8 months ago (2011-08-19 18:39:16 UTC) #9
juantrujillo
12 years, 8 months ago (2011-08-19 20:06:56 UTC) #10
juantrujillo
12 years, 8 months ago (2011-08-19 20:11:57 UTC) #11
berrada
12 years, 8 months ago (2011-08-19 20:28:13 UTC) #12
LGTM, submitted in r13472.

On Fri, Aug 19, 2011 at 1:11 PM, <juantrujillo@google.com> wrote:

>
http://codereview.appspot.com/**4810080/<http://codereview.appspot.com/4810080/>
>



-- 
Dounia
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b