Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(294)

Issue 4809057: Ends of barlines are hidden in staff lines. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by Janek Warchol
Modified:
7 years, 9 months ago
Reviewers:
janek, james.lowe, Neil Puttock, c_sorensen, MikeSol, pkx166h, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Ends of barlines are hidden in staff lines. Barlines are made a little shorter, so that the end of the barline doesn't touch the outer edge of staff line - it ends in the middle of staff line now. This prevets artifacts in pdf viewing and printing.

Patch Set 1 #

Total comments: 5

Patch Set 2 : simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M lily/bar-line.cc View 1 1 chunk +16 lines, -2 lines 0 comments Download

Messages

Total messages: 14
Janek Warchol
http://lists.gnu.org/archive/html/lilypond-devel/2011-07/msg01051.html 2011/7/27 Han-Wen Nienhuys <hanwenn@gmail.com>: > >>> Due to rounding, PDF viewers can err >>> ...
7 years, 11 months ago (2011-07-29 05:14:59 UTC) #1
hanwenn
On Fri, Jul 29, 2011 at 2:15 AM, <lemniskata.bernoullego@gmail.com> wrote: > Reviewers: hanwenn, > > ...
7 years, 11 months ago (2011-07-29 16:43:12 UTC) #2
Janek Warchol
2011/7/29 Han-Wen Nienhuys <hanwenn@gmail.com>: > On Fri, Jul 29, 2011 at 2:15 AM, <lemniskata.bernoullego@gmail.com> wrote: ...
7 years, 11 months ago (2011-07-30 16:07:47 UTC) #3
c_sorensen
On 7/30/11 10:07 AM, "Janek Warchoł" <lemniskata.bernoullego@gmail.com> wrote: > 2011/7/29 Han-Wen Nienhuys <hanwenn@gmail.com>: > >> ...
7 years, 11 months ago (2011-07-30 16:15:39 UTC) #4
pkx166h
On 2011/07/30 16:15:39, c_sorensen_byu.edu wrote: > > I think that the stop/start staves is currently ...
7 years, 11 months ago (2011-07-30 21:35:58 UTC) #5
pkx166h
passes make and reg tests look fine.
7 years, 11 months ago (2011-07-30 21:40:14 UTC) #6
Janek Warchol
2011/7/30 Carl Sorensen <c_sorensen@byu.edu>: > On 7/30/11 10:07 AM, "Janek Warchoł" wrote: >> Actually, there ...
7 years, 11 months ago (2011-07-30 22:54:05 UTC) #7
c_sorensen
On 7/30/11 3:35 PM, "pkx166h@gmail.com" <pkx166h@gmail.com> wrote: > On 2011/07/30 16:15:39, c_sorensen_byu.edu wrote: > > ...
7 years, 11 months ago (2011-07-30 23:19:06 UTC) #8
James.Lowe_datacore.com
Hello, ________________________________________ From: lilypond-devel-bounces+james.lowe=datacore.com@gnu.org [lilypond-devel-bounces+james.lowe=datacore.com@gnu.org] on behalf of Carl Sorensen [c_sorensen@byu.edu] Sent: 31 July 2011 ...
7 years, 11 months ago (2011-07-30 23:26:46 UTC) #9
c_sorensen
On 7/30/11 5:26 PM, "James Lowe" <James.Lowe@datacore.com> wrote: > > OK I see (although I ...
7 years, 11 months ago (2011-07-30 23:30:59 UTC) #10
Neil Puttock
http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc File lily/bar-line.cc (right): http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc#newcode40 lily/bar-line.cc:40: /* Due to rounding problems, barlines extending to the ...
7 years, 10 months ago (2011-08-13 15:55:06 UTC) #11
janek
Does this qualify for a regtest? http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc File lily/bar-line.cc (right): http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc#newcode48 lily/bar-line.cc:48: SCM staff_color = ...
7 years, 10 months ago (2011-08-22 14:54:26 UTC) #12
MikeSol
Make sure to consider cases like: \relative c'' { \stopStaff \override Staff.StaffSymbol #'line-count = #1 ...
7 years, 10 months ago (2011-08-25 07:59:35 UTC) #13
janek
7 years, 9 months ago (2011-09-06 06:28:40 UTC) #14
On 2011/08/25 07:59:35, MikeSol wrote:
> Make sure to consider cases like:
> 
> \relative c'' {
>   \stopStaff
>   \override Staff.StaffSymbol #'line-count = #1
>   \startStaff
>   b1
>   \stopStaff
>   \revert Staff.StaffSymbol #'line-count
>   \startStaff
>   b1
> }

There are no problems with this example.

Pushed as b92ea16ef75d8aaa7bdb9f492b58d7af906e7945
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b