Issue 4808078: Advanced Touch API - Scroll using WebView

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4808078: Advanced Touch API - Scroll using WebView

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by juantrujillo

Modified:
12 years, 8 months ago

Reviewers:
Eran, berrada

CC:
webdriver-eng_google.com

Base URL:
http://selenium.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Advanced Touch API - Scroll using WebView #

Patch Set 3 : Advanced Touch API - Scroll using WebView - Indentation fixes #

Patch Set 4 : Scroll using View #

Patch Set 5 : Scroll with WebView #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -9 lines)			Patch
M	android/src/java/org/openqa/selenium/android/ActivityController.java	View	1 2 3 4	5 chunks	+25 lines, -2 lines	0 comments	Download
M	android/src/java/org/openqa/selenium/android/AndroidTouchScreen.java	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	android/src/java/org/openqa/selenium/android/app/MainActivity.java	View	1 2 3 4	7 chunks	+18 lines, -6 lines	0 comments	Download
M	java/client/src/org/openqa/selenium/TouchScreen.java	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	java/client/src/org/openqa/selenium/interactions/touch/ScrollAction.java	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	java/client/src/org/openqa/selenium/interactions/touch/TouchActions.java	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	java/client/src/org/openqa/selenium/remote/HttpCommandExecutor.java	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	java/client/src/org/openqa/selenium/remote/RemoteTouchScreen.java	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	java/client/src/org/openqa/selenium/support/events/internal/EventFiringTouch.java	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	java/server/src/org/openqa/selenium/remote/server/DriverServlet.java	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

berrada

12 years, 8 months ago (2011-08-19 17:41:48 UTC) #6

LGTM, submitted in r13471

On Fri, Aug 19, 2011 at 10:25 AM, <juantrujillo@google.com> wrote:

>
http://codereview.appspot.com/**4808078/<http://codereview.appspot.com/4808078/>
>



-- 
Dounia

Expand All Messages | Collapse All Messages