Issue 4802062: Remove Google Base support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4802062: Remove Google Base support

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by Ali Afshar

Modified:
12 years, 9 months ago

Reviewers:
jcgregorio

CC:
gdata-python-client-library-contributors_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Removed files from manifest. #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, -5024 lines)			Patch
M	MANIFEST	View	1	6 chunks	+0 lines, -12 lines	0 comments	Download
R	pydocs/gdata.base.html	View		1 chunk	+0 lines, -2100 lines	0 comments	Download
R	pydocs/gdata.base.service.html	View		1 chunk	+0 lines, -1047 lines	0 comments	Download
R	samples/base/baseAttributesQueryExample.py	View		1 chunk	+0 lines, -47 lines	0 comments	Download
R	samples/base/baseItemTypesQueryExample.py	View		1 chunk	+0 lines, -42 lines	0 comments	Download
R	samples/base/baseQueryExample.py	View		1 chunk	+0 lines, -51 lines	0 comments	Download
R	samples/base/dryRunInsert.py	View		1 chunk	+0 lines, -60 lines	0 comments	Download
M	setup.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
R	src/gdata/base/__init__.py	View		1 chunk	+0 lines, -746 lines	0 comments	Download
R	src/gdata/base/service.py	View		1 chunk	+0 lines, -256 lines	0 comments	Download
R	tests/gdata_tests/base/__init__.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
R	tests/gdata_tests/base/data_test.py	View		1 chunk	+0 lines, -94 lines	0 comments	Download
R	tests/gdata_tests/base/service_test.py	View		1 chunk	+0 lines, -224 lines	0 comments	Download
R	tests/gdata_tests/base_test.py	View		1 chunk	+0 lines, -345 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jcgregorio

I always like removing code! Please also remove files from MANIFEST. On 2011/07/28 12:41:19, Ali ...

12 years, 9 months ago (2011-07-28 13:54:09 UTC) #2

Ali Afshar

On 2011/07/28 13:54:09, jcgregorio wrote: > I always like removing code! > > Please also ...

12 years, 9 months ago (2011-07-28 13:59:50 UTC) #4

jcgregorio

12 years, 9 months ago (2011-07-28 14:09:27 UTC) #5

LGTM 

On 2011/07/28 13:59:50, Ali Afshar wrote:
> On 2011/07/28 13:54:09, jcgregorio wrote:
> > I always like removing code!
> > 
> > Please also remove files from MANIFEST.
> > 
> > On 2011/07/28 12:41:19, Ali Afshar wrote:
> 
> Done

Expand All Messages | Collapse All Messages