Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1490)

Issue 4802060: Use Thumbnail for news story list, rather than image (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by jeremy.wadsack
Modified:
12 years, 7 months ago
Base URL:
http://npr-android-app.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Per suggestion by Jeremy Pennycook, I have changed the news list adapter to use the first thumbnail image (if there is one) for the story in the news list, rather than the first image. This should: (1) improve list loading speed, (2) ensure that thumbnails are square and cropped by NPR's editorial (hopefully). However it will cause the actual image to load when the story loads, rather than being cached from the list. In brief tests, the performance seems just fine though.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
Npr/src/org/npr/android/news/NewsListAdapter.java View 1 chunk +8 lines, -3 lines 0 comments Download
Npr/src/org/npr/api/Story.java View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 3
jeremy.wadsack
12 years, 9 months ago (2011-07-25 23:04:21 UTC) #1
Marsh
Looks good except for one really minor nit http://codereview.appspot.com/4802060/diff/1/Npr/src/org/npr/api/Story.java File Npr/src/org/npr/api/Story.java (right): http://codereview.appspot.com/4802060/diff/1/Npr/src/org/npr/api/Story.java#newcode73 Npr/src/org/npr/api/Story.java:73: public ...
12 years, 9 months ago (2011-07-26 02:00:30 UTC) #2
jeremy.wadsack
12 years, 9 months ago (2011-07-26 04:33:52 UTC) #3
Mmm, right. I'll fix that and commit it.

Thanks!

--
Jeremy Wadsack


On Mon, Jul 25, 2011 at 7:00 PM, <marshgosnell@gmail.com> wrote:

> Looks good except for one really minor nit
>
>
> http://codereview.appspot.com/**4802060/diff/1/Npr/src/org/**
>
npr/api/Story.java<http://codereview.appspot.com/4802060/diff/1/Npr/src/org/npr/api/Story.java>
> File Npr/src/org/npr/api/Story.java (right):
>
> http://codereview.appspot.com/**4802060/diff/1/Npr/src/org/**
>
npr/api/Story.java#newcode73<http://codereview.appspot.com/4802060/diff/1/Npr/src/org/npr/api/Story.java#newcode73>
> Npr/src/org/npr/api/Story.**java:73: public String getMedium() {
> Need a blank line before new method
>
>
>
http://codereview.appspot.com/**4802060/<http://codereview.appspot.com/4802060/>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b