Factor out commonly needed plugin environment

* Removes Callback and various subtly different implementations of PluginEnvironment intended to do the same thing
* Replace with "permissive" plugin environment
* Adds a message queue so better error messages can be reported

[MikeSamuel, 2010-03-13 01:28:49]

Why is the PluginEnvironment responsible for deciding the appropriate error
message and levels when a lookup fails?

[Jasvir, 2010-04-05 23:18:31]

It shouldn't be.  Removed mq from the plugin environment

On 2010/03/13 01:28:49, MikeSamuel wrote:
> Why is the PluginEnvironment responsible for deciding the appropriate error
> message and levels when a lookup fails?

[MikeSamuel, 2010-04-06 01:27:58]

http://codereview.appspot.com/480041/diff/7001/8005
File src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java
(right):

http://codereview.appspot.com/480041/diff/7001/8005#newcode41
src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java:41:
PluginEnvironment.PERMISSIVE_PLUGIN_ENVIRONMENT;
Is this is an intentional change in behavior?
Permissive does seem to load external resources.

http://codereview.appspot.com/480041/diff/7001/8001
File src/com/google/caja/opensocial/GadgetRewriterMain.java (right):

http://codereview.appspot.com/480041/diff/7001/8001#newcode76
src/com/google/caja/opensocial/GadgetRewriterMain.java:76: Callback cb = new
Callback(mc, originalSources);
Is this line still needed?
Won't this break debugging, if the sources are no longer being captured?

http://codereview.appspot.com/480041/diff/7001/8002
File src/com/google/caja/plugin/PluginEnvironment.java (right):

http://codereview.appspot.com/480041/diff/7001/8002#newcode27
src/com/google/caja/plugin/PluginEnvironment.java:27: import
com.google.caja.service.FetchedData;
Did the plugin package previously depend on the service package?
Can FetchedData move around if need be?
Can we not have the FetchedData ctor load from a URL?  That seems a rather large
side effect to have happen in a ctor.

http://codereview.appspot.com/480041/diff/7001/8003
File src/com/google/caja/service/CajolingService.java (right):

http://codereview.appspot.com/480041/diff/7001/8003#newcode23
src/com/google/caja/service/CajolingService.java:23: import java.util.Vector;
Why move these?

http://codereview.appspot.com/480041/diff/7001/8004
File src/com/google/caja/service/CajolingServlet.java (right):

http://codereview.appspot.com/480041/diff/7001/8004#newcode22
src/com/google/caja/service/CajolingServlet.java:22: import
javax.servlet.http.HttpServletResponse;
Why move?

http://codereview.appspot.com/480041/diff/7001/8004#newcode55
src/com/google/caja/service/CajolingServlet.java:55: public CajolingServlet() {
If an HTTP server or something needs a zero-arg ctor, please add a comment to
that effect.

[Jasvir, 2010-04-06 23:15:41]

http://codereview.appspot.com/480041/diff/7001/8005
File src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java
(right):

http://codereview.appspot.com/480041/diff/7001/8005#newcode41
src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java:41:
PluginEnvironment.PERMISSIVE_PLUGIN_ENVIRONMENT;
Yes this is an intentional change to allow the playground to load referenced
scripts and styles.

On 2010/04/06 01:27:58, MikeSamuel wrote:
> Is this is an intentional change in behavior?
> Permissive does seem to load external resources.

http://codereview.appspot.com/480041/diff/7001/8001
File src/com/google/caja/opensocial/GadgetRewriterMain.java (right):

http://codereview.appspot.com/480041/diff/7001/8001#newcode76
src/com/google/caja/opensocial/GadgetRewriterMain.java:76: Callback cb = new
Callback(mc, originalSources);
On 2010/04/06 01:27:58, MikeSamuel wrote:
> Is this line still needed?
> Won't this break debugging, if the sources are no longer being captured?

Done.

http://codereview.appspot.com/480041/diff/7001/8002
File src/com/google/caja/plugin/PluginEnvironment.java (right):

http://codereview.appspot.com/480041/diff/7001/8002#newcode27
src/com/google/caja/plugin/PluginEnvironment.java:27: import
com.google.caja.service.FetchedData;
Moved FetchedData to the plugin package and changed FetchedData to load contents
of a url lazily.

On 2010/04/06 01:27:58, MikeSamuel wrote:
> Did the plugin package previously depend on the service package?
> Can FetchedData move around if need be?
> Can we not have the FetchedData ctor load from a URL?  That seems a rather
large
> side effect to have happen in a ctor.

http://codereview.appspot.com/480041/diff/7001/8004
File src/com/google/caja/service/CajolingServlet.java (right):

http://codereview.appspot.com/480041/diff/7001/8004#newcode55
src/com/google/caja/service/CajolingServlet.java:55: public CajolingServlet() {
On 2010/04/06 01:27:58, MikeSamuel wrote:
> If an HTTP server or something needs a zero-arg ctor, please add a comment to
> that effect.

Done.

[Jasvir, 2010-04-06 23:16:07]

snapshot

[Jasvir, 2010-04-09 22:24:58]

snapshot

[Jasvir, 2010-05-10 01:36:06]

ping

[Jasvir, 2010-05-27 18:30:09]

This change is mostly obsoleted by http://codereview.appspot.com/1123044/show. 
I'll submit the small difference in a separate change.