Split PluginEnvironment into separate fetcher and policy objects

This is in preparation for reworking the URI policy to be expressible
in Cajita and to receive more context about the URI received.

[Jasvir, 2010-05-12 00:03:10]

Can you make sure that all instances that eventually use URLConnection
(fr'instance GWTCajolingService.fetch) use the new URI fetcher.

http://codereview.appspot.com/1123044/diff/1/59
File src/com/google/caja/ancillary/servlet/Request.java (right):

http://codereview.appspot.com/1123044/diff/1/59#newcode23
src/com/google/caja/ancillary/servlet/Request.java:23: import
com.google.caja.lexer.GuessContentType;
This is needed because GuessContentType moved out of the servlet package.

http://codereview.appspot.com/1123044/diff/1/18
File src/com/google/caja/lexer/GuessContentType.java (right):

http://codereview.appspot.com/1123044/diff/1/18#newcode33
src/com/google/caja/lexer/GuessContentType.java:33: public static ContentType
guess(
Please include docstring explaining the order of preference the heuristic uses
to guess mime type.

http://codereview.appspot.com/1123044/diff/1/53
File src/com/google/caja/util/Charsets.java (right):

http://codereview.appspot.com/1123044/diff/1/53#newcode23
src/com/google/caja/util/Charsets.java:23: public static final Charset UTF_8 =
Charset.forName("UTF-8");
Charset.forName can throw a RuntimeException but the library explicitly says
UTF-8 must be provided by any implementation.

http://codereview.appspot.com/1123044/diff/1/8
File tests/com/google/caja/parser/css/CssParserTest.java (right):

http://codereview.appspot.com/1123044/diff/1/8#newcode196
tests/com/google/caja/parser/css/CssParserTest.java:196:
System.err.println("css=" + css);
Cruft

[MikeSamuel, 2010-05-12 00:29:21]

I changed GWTCajolingServiceImpl to take a uri fetcher.  I'm not sure this
addresses the problem.  I think that class is created reflectively by GWT so I'm
not sure how to thread an appropriate fetcher through.

The current set of places where we're going over the network is mostly in main
classes and major entry points. 

find src/ -name \*.java | xargs egrep '\.openStream\(|\.openConnection\('
src/com/google/caja/opensocial/GadgetUriFetcher.java:      data =
FetchedData.fromConnection(uri.toURL().openConnection());
src/com/google/caja/plugin/PluginCompilerMain.java:        createReader(is,
input.toURL().openStream()), is);
src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java:        
     ref.getUri().toURL().openConnection());
src/com/google/caja/service/CajolingService.java:             
ref.getUri().toURL().openConnection());
src/com/google/caja/ancillary/servlet/UriFetcher.java:    URLConnection conn =
uri.toURL().openConnection();

http://codereview.appspot.com/1123044/diff/1/18
File src/com/google/caja/lexer/GuessContentType.java (right):

http://codereview.appspot.com/1123044/diff/1/18#newcode33
src/com/google/caja/lexer/GuessContentType.java:33: public static ContentType
guess(
On 2010/05/12 00:03:11, jasvir wrote:
> Please include docstring explaining the order of preference the heuristic uses
> to guess mime type.

Done.

http://codereview.appspot.com/1123044/diff/1/8
File tests/com/google/caja/parser/css/CssParserTest.java (right):

http://codereview.appspot.com/1123044/diff/1/8#newcode196
tests/com/google/caja/parser/css/CssParserTest.java:196:
System.err.println("css=" + css);
On 2010/05/12 00:03:11, jasvir wrote:
> Cruft

Done.

[Jasvir, 2010-05-12 21:48:04]

LGTM