Extension of ChromeDriver to support HTML5 webstorage atoms

[Eran, 2011-07-20 12:41:59]

http://codereview.appspot.com/4796041/diff/1/java/client/src/org/openqa/selen...
File java/client/src/org/openqa/selenium/chrome/ChromeDriver.java (left):

http://codereview.appspot.com/4796041/diff/1/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeDriver.java:117: }
Rather than making execute public, make the ChromeLocalStorage an inner class of
the ChromeDriver. Actually, the ChromeLocalStorage is not specific to Chrome -
it may as well be called RemoteLocalStorage (have a look at the RemoteMouse
class) and live as a part of the RemoteWebDriver. This way, when the
FirefoxDriver supports LocalStorage, all we'd have to do is get the methods
implemented in the FirefoxDriver.

The bigger problem here is that there's no way to delegate responsibility
outside of the RemoteWebDriver because the access to execute() method is
limited. Simon suggested a delegation object that will be provided by the
RemoteWebDriver and will invoke execute on your behalf.

[Nayeem, 2011-08-03 03:41:46]

I have uploaded the patchset for ChromeDriver of the client-side and it now uses
the RemoteLocalStorage and RemoteSessionStorage class. 

This CL is dependent on  #4667069.

The server side of the code is submitted as a separate CL and goes to chrome
repository

-Nayeem
On 2011/07/20 12:41:59, Eran wrote:
>
http://codereview.appspot.com/4796041/diff/1/java/client/src/org/openqa/selen...
> File java/client/src/org/openqa/selenium/chrome/ChromeDriver.java (left):
> 
>
http://codereview.appspot.com/4796041/diff/1/java/client/src/org/openqa/selen...
> java/client/src/org/openqa/selenium/chrome/ChromeDriver.java:117: }
> Rather than making execute public, make the ChromeLocalStorage an inner class
of
> the ChromeDriver. Actually, the ChromeLocalStorage is not specific to Chrome -
> it may as well be called RemoteLocalStorage (have a look at the RemoteMouse
> class) and live as a part of the RemoteWebDriver. This way, when the
> FirefoxDriver supports LocalStorage, all we'd have to do is get the methods
> implemented in the FirefoxDriver.
> 
> The bigger problem here is that there's no way to delegate responsibility
> outside of the RemoteWebDriver because the access to execute() method is
> limited. Simon suggested a delegation object that will be provided by the
> RemoteWebDriver and will invoke execute on your behalf.

[berrada, 2011-08-04 20:01:52]

http://codereview.appspot.com/4796041/diff/9001/javascript/chrome-driver/buil...
File javascript/chrome-driver/build.desc (right):

http://codereview.appspot.com/4796041/diff/9001/javascript/chrome-driver/buil...
javascript/chrome-driver/build.desc:56:
"//javascript/webdriver-atoms:get_local_storage_item:chrome",
Revert this. The header file should be modified as you add the support for those
apis. Split this up in the respective CLs.

[Nayeem, 2011-08-04 20:57:40]

http://codereview.appspot.com/4796041/diff/9001/javascript/chrome-driver/buil...
File javascript/chrome-driver/build.desc (right):

http://codereview.appspot.com/4796041/diff/9001/javascript/chrome-driver/buil...
javascript/chrome-driver/build.desc:56:
"//javascript/webdriver-atoms:get_local_storage_item:chrome",
On 2011/08/04 20:01:53, berrada wrote:
> Revert this. The header file should be modified as you add the support for
those
> apis. Split this up in the respective CLs.

Done.

[berrada, 2011-08-08 20:29:23]

LGTM. This needs to go in after the server side.

On 2011/08/04 20:57:40, Nayeem wrote:
>
http://codereview.appspot.com/4796041/diff/9001/javascript/chrome-driver/buil...
> File javascript/chrome-driver/build.desc (right):
> 
>
http://codereview.appspot.com/4796041/diff/9001/javascript/chrome-driver/buil...
> javascript/chrome-driver/build.desc:56:
> "//javascript/webdriver-atoms:get_local_storage_item:chrome",
> On 2011/08/04 20:01:53, berrada wrote:
> > Revert this. The header file should be modified as you add the support for
> those
> > apis. Split this up in the respective CLs.
> 
> Done.