code review 4795042: sync/atomic: delete workaround

sync/atomic: delete workaround
Load seems to work on arm now.

[dsymonds, 2011-07-19 22:38:43]

LGTM

[r, 2011-07-19 22:39:22]

Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-07-19 22:42:24]

LGTM

On Tue, Jul 19, 2011 at 3:39 PM, <r@golang.org> wrote:

> Reviewers: dsymonds,
>
> Message:
> Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> sync/atomic: delete workaround
> Load seems to work on arm now.
>
> Please review this at
http://codereview.appspot.com/**4795042/<http://codereview.appspot.com/4795042/>
>
> Affected files:
>  src/pkg/sync/atomic/atomic_**test.go
>
>
> Index: src/pkg/sync/atomic/atomic_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/sync/atomic/atomic_**test.go
> +++ b/src/pkg/sync/atomic/atomic_**test.go
> @@ -309,9 +309,6 @@
>  }
>
>  func TestLoadInt32(t *testing.T) {
> -       if runtime.GOARCH == "arm" && testing.Short() {
> -               return /* TODO: broken on arm */
> -       }
>        var x struct {
>                before int32
>                i      int32
> @@ -332,9 +329,6 @@
>  }
>
>  func TestLoadUint32(t *testing.T) {
> -       if runtime.GOARCH == "arm" && testing.Short() {
> -               return /* TODO: broken on arm */
> -       }
>        var x struct {
>                before uint32
>                i      uint32
> @@ -622,9 +616,6 @@
>  }
>
>  func TestHammerLoad(t *testing.T) {
> -       if runtime.GOARCH == "arm" && testing.Short() {
> -               return /* TODO: broken on arm */
> -       }
>        tests := [...]func(*testing.T, *uint32){hammerLoadInt32,
> hammerLoadUint32}
>        n := 100000
>        if testing.Short() {
>
>
>

[r, 2011-07-19 22:54:15]

*** Abandoned ***

[r2, 2011-07-19 22:55:37]

this is a lie. it went in.  something is very broken in cloudville

On Jul 20, 2011, at 8:54 AM, r@golang.org wrote:

> *** Abandoned ***
> 
> http://codereview.appspot.com/4795042/