Code review - Issue 4795042: code review 4795042: sync/atomic: delete workaroundhttps://codereview.appspot.com/2011-07-19T22:55:37+00:00rietveld
Message from unknown
2011-07-19T22:28:13+00:00rurn:md5:f39137bafeb2565eec7c4e3aba0690ab
Message from unknown
2011-07-19T22:33:10+00:00rurn:md5:4c7797925a8e7dce0cc898408b7f7a40
Message from dsymonds@golang.org
2011-07-19T22:38:43+00:00dsymondsurn:md5:8b68662f01292520a728695fd8e33989
LGTM
Message from unknown
2011-07-19T22:38:57+00:00rurn:md5:1f7816172afe4219f76127411b89d540
Message from r@golang.org
2011-07-19T22:39:22+00:00rurn:md5:515144a4b69a5cb7daedb42071e4a368
Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from bradfitz@golang.org
2011-07-19T22:42:24+00:00bradfitzurn:md5:7b2a88ffde1481b668e49744da0d660d
LGTM
On Tue, Jul 19, 2011 at 3:39 PM, <r@golang.org> wrote:
> Reviewers: dsymonds,
>
> Message:
> Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> sync/atomic: delete workaround
> Load seems to work on arm now.
>
> Please review this at http://codereview.appspot.com/**4795042/<http://codereview.appspot.com/4795042/>
>
> Affected files:
> src/pkg/sync/atomic/atomic_**test.go
>
>
> Index: src/pkg/sync/atomic/atomic_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/sync/atomic/atomic_**test.go
> +++ b/src/pkg/sync/atomic/atomic_**test.go
> @@ -309,9 +309,6 @@
> }
>
> func TestLoadInt32(t *testing.T) {
> - if runtime.GOARCH == "arm" && testing.Short() {
> - return /* TODO: broken on arm */
> - }
> var x struct {
> before int32
> i int32
> @@ -332,9 +329,6 @@
> }
>
> func TestLoadUint32(t *testing.T) {
> - if runtime.GOARCH == "arm" && testing.Short() {
> - return /* TODO: broken on arm */
> - }
> var x struct {
> before uint32
> i uint32
> @@ -622,9 +616,6 @@
> }
>
> func TestHammerLoad(t *testing.T) {
> - if runtime.GOARCH == "arm" && testing.Short() {
> - return /* TODO: broken on arm */
> - }
> tests := [...]func(*testing.T, *uint32){hammerLoadInt32,
> hammerLoadUint32}
> n := 100000
> if testing.Short() {
>
>
>
Message from r@golang.org
2011-07-19T22:54:15+00:00rurn:md5:3189d758fea265781d27dc0d109ccd61
*** Abandoned ***
Message from r@google.com
2011-07-19T22:55:37+00:00r2urn:md5:e474df7b5cb8723918cda7feee6b7f6f
this is a lie. it went in. something is very broken in cloudville
On Jul 20, 2011, at 8:54 AM, r@golang.org wrote:
> *** Abandoned ***
>
> http://codereview.appspot.com/4795042/