Issue 47950043: code review 47950043: runtime: Fix panic when trying to stop CPU profiling wi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 47950043: code review 47950043: runtime: Fix panic when trying to stop CPU profiling wi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by cehessman

Modified:
11 years, 10 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

runtime: Fix panic when trying to stop CPU profiling with profiler turned off Fixes issue 7063.

Patch Set 2 : diff -r 9d0f388bbe40 https://code.google.com/p/go #

Patch Set 3 : diff -r 9d0f388bbe40 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 9d0f388bbe40 https://code.google.com/p/go #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/pkg/runtime/cpuprof.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/runtime/runtime_test.go	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

cehessman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 10 months ago (2014-01-05 19:34:22 UTC) #1

iant

https://codereview.appspot.com/47950043/diff/40001/src/pkg/runtime/runtime_test.go File src/pkg/runtime/runtime_test.go (right): https://codereview.appspot.com/47950043/diff/40001/src/pkg/runtime/runtime_test.go#newcode130 src/pkg/runtime/runtime_test.go:130: // Test stop CPU profiling with profiler turned off. ...

11 years, 10 months ago (2014-01-06 02:42:48 UTC) #2

cehessman

Hello golang-codereviews@googlegroups.com, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

11 years, 10 months ago (2014-01-06 06:09:25 UTC) #3

iant

11 years, 10 months ago (2014-01-06 17:53:59 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=3b65d95e81d1 ***

runtime: Fix panic when trying to stop CPU profiling with profiler turned off

Fixes issue 7063.

R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/47950043

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages