Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(261)

Issue 4777044: Creates a glissando stem grob that uses stems' functionality.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by MikeSol
Modified:
7 years, 10 months ago
Reviewers:
mike, pkx166h, Neil Puttock, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Creates a glissando stem grob that uses stems' functionality.

Patch Set 1 : Passes regtests. #

Total comments: 4

Patch Set 2 : Updates input syntax, adds script support. #

Patch Set 3 : Merges glissando work with the current master. #

Patch Set 4 : Removes valgrind. #

Patch Set 5 : Fixes offset of glissando stem scripts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+729 lines, -56 lines) Patch
A input/regression/glissando-stem.ly View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download
M lily/glissando-engraver.cc View 1 2 4 chunks +12 lines, -0 lines 0 comments Download
A lily/glissando-stem.cc View 1 2 3 1 chunk +284 lines, -0 lines 0 comments Download
A lily/glissando-stem-script-interface.cc View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
A lily/include/glissando-stem.hh View 1 1 chunk +37 lines, -0 lines 0 comments Download
A lily/include/glissando-stem-script-interface.hh View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
M lily/include/stem.hh View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M lily/include/stem-tremolo.hh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lily/script-engraver.cc View 1 2 6 chunks +34 lines, -1 line 0 comments Download
M lily/separation-item.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M lily/stem.cc View 1 2 14 chunks +27 lines, -10 lines 0 comments Download
M lily/stem-engraver.cc View 1 2 9 chunks +29 lines, -8 lines 0 comments Download
M lily/stem-tremolo.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M scm/define-event-classes.scm View 1 chunk +2 lines, -1 line 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 4 4 chunks +59 lines, -31 lines 0 comments Download
M scm/define-music-types.scm View 1 1 chunk +6 lines, -0 lines 0 comments Download
A scm/layout-stem.scm View 1 chunk +48 lines, -0 lines 0 comments Download
M scm/lily.scm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scm/output-lib.scm View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 12
MikeSol
Tries to minimize overlap with stem.cc - Glissando_stem::has_interface now appears four (indispensable) times in stem.cc. ...
7 years, 11 months ago (2011-07-20 12:32:54 UTC) #1
hanwenn
On Wed, Jul 20, 2011 at 9:32 AM, <mtsolo@gmail.com> wrote: > A lot of files ...
7 years, 11 months ago (2011-07-20 15:27:34 UTC) #2
hanwenn
http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 lily/beam.cc:706: Interval positions = robust_scm2interval ((*s)->get_property ("head-positions"), Interval (0,0)); rather ...
7 years, 11 months ago (2011-07-20 15:31:57 UTC) #3
mike_apollinemike.com
On Jul 20, 2011, at 5:31 PM, hanwenn@gmail.com wrote: > > http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc > File lily/beam.cc ...
7 years, 11 months ago (2011-07-20 16:05:17 UTC) #4
Neil Puttock
http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly File input/regression/glissando-stem.ly (right): http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly#newcode10 input/regression/glissando-stem.ly:10: \xenakisStem #(ly:make-duration 3) #32 This should be a music ...
7 years, 11 months ago (2011-07-20 16:27:34 UTC) #5
mike_apollinemike.com
On Jul 20, 2011, at 6:27 PM, n.puttock@gmail.com wrote: > > http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly > File input/regression/glissando-stem.ly ...
7 years, 11 months ago (2011-07-20 20:04:46 UTC) #6
hanwenn
On Wed, Jul 20, 2011 at 1:05 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: >> http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 >> lily/beam.cc:706: ...
7 years, 11 months ago (2011-07-21 02:30:52 UTC) #7
hanwenn
On Wed, Jul 20, 2011 at 11:30 PM, Han-Wen Nienhuys <hanwenn@gmail.com> wrote: >>> http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 >>> ...
7 years, 11 months ago (2011-07-21 02:35:51 UTC) #8
MikeSol
I've merged my glissando stem work with current master. It passes regtests and can currently ...
7 years, 10 months ago (2011-08-06 16:01:03 UTC) #9
pkx166h
make fails. --snip-- -DHAVE_CONFIG_H -DNDEBUG -I/home/jlowe/lilypond-git/lily/include -I./out -I/home/jlowe/lilypond-git/flower/include -I../flower/./out -I../flower/include -I/home/jlowe/lilypond-git/lily/out -O2 -finline-functions -g -pipe ...
7 years, 10 months ago (2011-08-06 20:56:14 UTC) #10
mike_apollinemike.com
On Aug 6, 2011, at 10:56 PM, pkx166h@gmail.com wrote: > make fails. > > --snip-- ...
7 years, 10 months ago (2011-08-07 09:17:09 UTC) #11
MikeSol
7 years, 10 months ago (2011-08-10 16:18:44 UTC) #12
New patch set up that gets Y-offset right for glissando stem scripts.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b