Issue 47670043: code review 47670043: go.tools/go/ssa: simplify builder.exprN now that go/typ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 47670043: code review 47670043: go.tools/go/ssa: simplify builder.exprN now that go/typ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by adonovan

Modified:
11 years, 5 months ago

Reviewers:
gri

CC:
gri, golang-codereviews

Visibility:
Public.

Description

go.tools/go/ssa: simplify builder.exprN now that go/types emits correct types. (Follow-up to fix of issue 7060.) Also: comment fixes.

Patch Set 1 #

Patch Set 2 : diff -r 1d658e08a7da https://code.google.com/p/go.tools #

Patch Set 3 : diff -r d436368620c7 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r d436368620c7 https://code.google.com/p/go.tools #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -30 lines)			Patch
	M	go/ssa/builder.go	View	1 2	5 chunks	+13 lines, -30 lines	0 comments	Download
	M	go/ssa/interp/testdata/mrvchain.go	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 5 months ago (2014-01-17 04:27:34 UTC) #1

adonovan

11 years, 5 months ago (2014-01-17 14:38:27 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=6de96abd0141&repo=tools ***

go.tools/go/ssa: simplify builder.exprN now that go/types emits correct types.

(Follow-up to fix of issue 7060.)

Also: comment fixes.

R=gri
CC=golang-codereviews
https://codereview.appspot.com/47670043

Expand All Messages | Collapse All Messages