Issue 4764043: Remove custom JPA EMF/EM/EntityTransaction and JDO Transaction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4764043: Remove custom JPA EMF/EM/EntityTransaction and JDO Transaction (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by datanucleus

Modified:
12 years, 9 months ago

Reviewers:
maxr

Base URL:
http://datanucleus-appengine.googlecode.com/svn/trunk/trunk/

Visibility:
Public.

Description

A StoreManager can easily be notified of when a txn starts, commits, rolls back. As a result the logic in DatastoreEntityTransaction and DatastoreJDOTransaction can be removed. This means that the custom JPA EMF/PersistenceProvider is also not needed. The remaining work to get rid of the custom PMF/PM will involve separate work on the bulk loading, and fetch fields (to be included later). PS, this change is applied to SVN trunk, but since it is significant is included here for "review".

Patch Set 1 #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+49 lines, -380 lines)			Patch
demos/helloorm/src/META-INF/persistence.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
src/META-INF/services/javax.persistence.spi.PersistenceProvider	View	1 chunk	+0 lines, -1 line	0 comments	Download
src/com/google/appengine/datanucleus/DatastoreManager.java	View	3 chunks	+36 lines, -7 lines	0 comments	Download
src/com/google/appengine/datanucleus/jdo/DatastoreJDOPersistenceManager.java	View	2 chunks	+0 lines, -12 lines	0 comments	Download
src/com/google/appengine/datanucleus/jdo/DatastoreJDOTransaction.java	View	1 chunk	+0 lines, -90 lines	0 comments	Download
src/com/google/appengine/datanucleus/jpa/DatastoreEntityManager.java	View	1 chunk	+0 lines, -43 lines	0 comments	Download
src/com/google/appengine/datanucleus/jpa/DatastoreEntityManagerFactory.java	View	1 chunk	+0 lines, -68 lines	0 comments	Download
src/com/google/appengine/datanucleus/jpa/DatastoreEntityTransactionImpl.java	View	1 chunk	+0 lines, -86 lines	0 comments	Download
src/com/google/appengine/datanucleus/jpa/DatastorePersistenceProvider.java	View	1 chunk	+0 lines, -58 lines	0 comments	Download
testing/library/src/META-INF/persistence.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
tests/META-INF/persistence.xml	View	6 chunks	+6 lines, -6 lines	0 comments	Download
tests/com/google/appengine/datanucleus/jpa/JPADataSourceConfigTest.java	View	3 chunks	+3 lines, -5 lines	0 comments	Download
tests/com/google/appengine/datanucleus/jpa/JPATestCase.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

maxr

12 years, 9 months ago (2011-07-17 21:59:47 UTC) #2

On 2011/07/17 08:49:33, datanucleus wrote:

Good riddance.  

Not entirely related to this CL, but consider renaming
DatastoreJDOPersistenceManagerFactoryTest and DatastoreEntityManagerFactoryTest
now that DatastoreJDOPersistenceManagerFactory and DatastoreEntityManagerFactory
no longer exist.

Expand All Messages | Collapse All Messages