Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 4754049: Drop custom PMF/PM, and move batch handler to standard DN API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by datanucleus
Modified:
12 years, 9 months ago
Reviewers:
maxr
Base URL:
http://datanucleus-appengine.googlecode.com/svn/trunk/trunk/
Visibility:
Public.

Description

The PersistenceHandler has hook methods for batchStart/batchEnd. Using these instead of overriding the PM methods means that 1. We can ditch the custom PMF/PM 2. We get correct JDO behaviour in terms of exception throwing (v1.x of GAE/J throws NucleusUserException which is simply wrong). Test updated accordingly to match correct JDO expectations from those methods

Patch Set 1 #

Messages

Total messages: 2
datanucleus
12 years, 9 months ago (2011-07-17 10:00:49 UTC) #1
maxr
12 years, 9 months ago (2011-07-17 22:01:20 UTC) #2
On 2011/07/17 10:00:49, datanucleus wrote:

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b