Support for query eval totally in-memory, and support for query of candidate collections/extents

This patch enables the use of candidateCollection/candidateExtent (a query can be provided with a set of instances that are to be queried) in the query. 

This patch also enables evaluation of queries totally in-memory when either
1. candidate collection/extent provided
2. use sets query extension "datanucleus.query.evaluateInMemory" to true.

Also includes 2 simple tests
1. in-memory evaluation of a clause not evaluatable in-datastore
2. evaluation of a query passing in candidate collection

Note that this does not include support for partial evaluation in-datastore and partial evaluation in-memory (i.e evaluate as much as possible in datastore as it can take and then do the rest in-memory) - that is still TODO

[maxr, 2011-07-13 05:14:53]

On 2011/07/12 18:00:10, datanucleus wrote:

How about similar tests for JPQL?

[maxr, 2011-07-13 05:20:55]

On 2011/07/13 05:14:53, maxr wrote:
> On 2011/07/12 18:00:10, datanucleus wrote:
> 
> How about similar tests for JPQL?

codereview tool is not letting me send in-line comments.  I think it's because
it can't fetch the original versions of the files you uploaded.

Anyway.

When you fall back to letting the datastore evaluate the query because you've
got a subquery alias, you might as well just fail the query because the
datastore doesn't support that.

Also, in the code where you're evaluating the value of the extension that
determines whether or not you can evaluate in memory, there's no need to check
the result of Boolean.valueOf() for null.  The whole block can be replaced with:
Boolean.valueOf can't return null, so you can replace all of this with 
return Boolean.valueOf((String) val);

(both these comments apply to the JPA code as well).

Thanks,
Max

[datanucleus, 2011-07-13 06:39:06]

Agreed about the Boolean.valueOf, and also the equivalent test to JPQLQueryTest
for in-memory evaluation. Note that you can't query over candidate
collections/extents with JPQL (from JPA API) since JPA doesn't allow that
(though you can using JPQL under JDO API).

[maxr, 2011-07-13 07:05:50]

Go ahead and submit once you've made those changes.

Thanks!

Max

On Wed, Jul 13, 2011 at 4:39 PM, <andy_jefferson@yahoo.com> wrote:

> Agreed about the Boolean.valueOf, and also the equivalent test to
> JPQLQueryTest for in-memory evaluation. Note that you can't query over
> candidate collections/extents with JPQL (from JPA API) since JPA doesn't
> allow that (though you can using JPQL under JDO API).
>
>
>
http://codereview.appspot.com/**4710043/<http://codereview.appspot.com/4710043/>
>