Issue 4707042: Remove duplicate EMF exception logic and make use of DN "singleton EMF" handler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4707042: Remove duplicate EMF exception logic and make use of DN "singleton EMF" handler (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by datanucleus

Modified:
12 years, 9 months ago

Reviewers:
maxr

Base URL:
http://datanucleus-appengine.googlecode.com/svn/trunk/trunk/

Visibility:
Public.

Description

DataNucleus has a handler to allocate singleton EMFs. If you set a persistence property "datanucleus.singletonEMFForName" then it will hand out a singleton instance of that EMF. If you subsequently try to create a EMF with that name then it returns the current (active) EMF for that name. This patch removes the previous exception logic and makes use of the builtin singleton handler. The tests are updated to test allocation of a singleton, and allocation of a non-singleton.

Patch Set 1 #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+75 lines, -116 lines)			Patch
src/com/google/appengine/datanucleus/jpa/DatastoreEntityManagerFactory.java	View	4 chunks	+2 lines, -74 lines	0 comments	Download
src/com/google/appengine/datanucleus/jpa/DatastorePersistenceProvider.java	View	3 chunks	+7 lines, -2 lines	0 comments	Download
tests/META-INF/persistence.xml	View	1 chunk	+15 lines, -0 lines	0 comments	Download
tests/com/google/appengine/datanucleus/DatastoreTestCase.java	View	2 chunks	+1 line, -5 lines	0 comments	Download
tests/com/google/appengine/datanucleus/jpa/DatastoreEntityManagerFactoryTest.java	View	1 chunk	+50 lines, -35 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2011/07/12 14:44:05, datanucleus wrote:

LGTM

Expand All Messages | Collapse All Messages