Issue 4702047: added never_spam, forward_to, should_trash, should_star to Email settings client

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by manoochehri

Modified:
11 years, 5 months ago

Reviewers:
Claudio Cherubino, rm7088, jcgregorio

CC:
gdata-python-client-library-contributors_googlegroups.com

Visibility:
Public.

Patch Set 2 : Responding to review comments, removed whitespace and corrected commets #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -51 lines)			Patch
M	src/gdata/apps/emailsettings/client.py	View	1	17 chunks	+54 lines, -42 lines	0 comments	Download
M	src/gdata/apps/emailsettings/data.py	View	1	8 chunks	+112 lines, -9 lines	0 comments	Download
M	tests/gdata_tests/apps/emailsettings/data_test.py	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	tests/gdata_tests/apps/emailsettings/live_client_test.py	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Claudio Cherubino

http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/client.py File src/gdata/apps/emailsettings/client.py (right): http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/client.py#newcode193 src/gdata/apps/emailsettings/client.py:193: message to "Spam" if it matches the specified filter ...

12 years, 9 months ago (2011-07-18 18:21:37 UTC) #2

manoochehri

On 2011/07/18 21:48:25, manoochehri wrote: Updated relevant files (see patch)

12 years, 9 months ago (2011-07-18 23:14:11 UTC) #4

Claudio Cherubino

On 2011/07/18 23:14:11, manoochehri wrote: > On 2011/07/18 21:48:25, manoochehri wrote: > > Updated relevant ...

12 years, 9 months ago (2011-07-18 23:17:51 UTC) #5

rm7088_bristol.ac.uk

11 years, 5 months ago (2012-11-15 16:06:03 UTC) #6

Heya,

Is there a reason that this change hasn't been merged? I'm happy to make 
any contributions that are needed but it all looks fine to me.

Thanks,
Rupert

On Monday, July 18, 2011 7:21:38 PM UTC+1, Claudio Cherubino wrote:
>
>
>
>
http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/cli...
> File src/gdata/apps/emailsettings/client.py (right):
>
>
>
http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/cli...
> src/gdata/apps/emailsettings/client.py:193: message to "Spam" if it
> matches the specified filter criteria.
> this should be "Trash" and not "Spam"
>
>
>
http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat...
> File src/gdata/apps/emailsettings/data.py (right):
>
>
>
http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat...
> src/gdata/apps/emailsettings/data.py:130:
> looks like there is some extra whitespace here and below.
> Did you run glint on the files?
>
>
>
http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat...
> src/gdata/apps/emailsettings/data.py:506: message to "Spam" if it
> matches the specified filter criteria.
> s/Spam/Trash
>
>
>
http://codereview.appspot.com/4702047/diff/1/src/gdata/apps/emailsettings/dat...
> src/gdata/apps/emailsettings/data.py:533: if forward_to is not None:
> use:
>
> if forward_to:
>
> http://codereview.appspot.com/4702047/
>
>

Expand All Messages | Collapse All Messages