Issue 4700046: Fixes failing ArrayIndexOptimizationTest and testObjectFreeze

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4700046: Fixes failing ArrayIndexOptimizationTest and testObjectFreeze (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by metaweta

Modified:
14 years, 8 months ago

Reviewers:
MikeSamuel, Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

In the latest version of Rhino, declaring a variable named 'undefined' throws an error. I'm not sure how I was able to submit the updated rhino without this test failing, but this fixes it. Also fixes testObjectFreeze; I don't know why this has just now started failing, since the bug has been around since at least 4295.

Patch Set 1 #

Patch Set 2 : Fixes failing ArrayIndexOptimizationTest #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	src/com/google/caja/es53.js	View	1	2 chunks	+9 lines, -6 lines	0 comments	Download
	M	tests/com/google/caja/parser/quasiliteral/opt/array-opt-operator-test.js	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Jasvir

14 years, 8 months ago (2011-07-13 22:50:11 UTC) #4

LGTM

The test that tests this change is the one causing the build to be red now.

Expand All Messages | Collapse All Messages