Issue 4698046: Support use of Version with inheritance

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4698046: Support use of Version with inheritance (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by datanucleus

Modified:
12 years, 9 months ago

Reviewers:
maxr

Base URL:
http://datanucleus-appengine.googlecode.com/svn/trunk/trunk/

Visibility:
Public.

Description

If you have a base class and subclass and the base has the version, and you persist a subclass, it doesn't get versioned currently. This is due to which metadata method is being called. This patch fixes it and adds a test. See also http://code.google.com/p/datanucleus-appengine/issues/detail?id=220&colspec=ID%20Stars%20Type%20Status%20Priority%20FoundIn%20TargetRelease%20Owner%20Summary

Patch Set 1 #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+69 lines, -4 lines)			Patch
src/com/google/appengine/datanucleus/DatastorePersistenceHandler.java	View	4 chunks	+7 lines, -4 lines	0 comments	Download
tests/com/google/appengine/datanucleus/jpa/JPAVersionTest.java	View	2 chunks	+17 lines, -0 lines	0 comments	Download
tests/com/google/appengine/datanucleus/test/BaseVersion.java	View	1 chunk	+23 lines, -0 lines	0 comments	Download
tests/com/google/appengine/datanucleus/test/BaseVersionSubclass.java	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2011/07/13 17:10:48, datanucleus wrote:

LGTM

Expand All Messages | Collapse All Messages