Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4627)

Issue 4695046: Remove duplicate PMF exception logic and make use of DN "singleton PMF" handler (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by datanucleus
Modified:
12 years, 9 months ago
Reviewers:
maxr
Base URL:
http://datanucleus-appengine.googlecode.com/svn/trunk/trunk/
Visibility:
Public.

Description

DataNucleus has a handler to allocate singleton PMFs. If you set a persistence property "datanucleus.singletonPMFForName" then it will hand out a singleton instance of that PMF. If you subsequently try to create a PMF with that name then it returns the current (active) PMF for that name. This patch removes the previous exception logic and makes use of the builtin singleton handler. The tests are updated to test allocation of a singleton, and allocation of a non-singleton.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -171 lines) Patch
src/com/google/appengine/datanucleus/jdo/DatastoreJDOPersistenceManagerFactory.java View 3 chunks +0 lines, -109 lines 0 comments Download
tests/META-INF/jdoconfig.xml View 1 chunk +15 lines, -0 lines 0 comments Download
tests/com/google/appengine/datanucleus/DatastoreTestCase.java View 3 chunks +0 lines, -12 lines 0 comments Download
tests/com/google/appengine/datanucleus/jdo/DatastoreJDOPersistenceManagerFactoryTest.java View 1 chunk +50 lines, -50 lines 0 comments Download

Messages

Total messages: 3
datanucleus
12 years, 9 months ago (2011-07-12 07:35:17 UTC) #1
maxr
On 2011/07/12 07:35:17, datanucleus wrote: Nice, I take it there's no similar property for JPA? ...
12 years, 9 months ago (2011-07-12 10:52:48 UTC) #2
datanucleus
12 years, 9 months ago (2011-07-12 11:05:11 UTC) #3
There is an equivalent property for JPA, but just not done that one yet ;-)

I upload the patch via the "Data" button on the form, and not via any Python
script. If I look at the text of the patch file it is correctly formed, so no
idea what the form does with it
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b