LGTM On Wed, Jan 1, 2014 at 3:55 AM, <shawn.p.smith@gmail.com> wrote: > Reviewers: golang-codereviews, > ...
11 years, 6 months ago
(2014-01-02 18:34:08 UTC)
#2
LGTM
On Wed, Jan 1, 2014 at 3:55 AM, <shawn.p.smith@gmail.com> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> encoding/hex: add Decode error test case
>
> Please review this at https://codereview.appspot.com/46880043/
>
> Affected files (+1, -0 lines):
> M src/pkg/encoding/hex/hex_test.go
>
>
> Index: src/pkg/encoding/hex/hex_test.go
> ===================================================================
> --- a/src/pkg/encoding/hex/hex_test.go
> +++ b/src/pkg/encoding/hex/hex_test.go
> @@ -82,6 +82,7 @@
> var errTests = []errTest{
> {"0", "encoding/hex: odd length hex string"},
> {"0g", "encoding/hex: invalid byte: U+0067 'g'"},
> + {"00gg", "encoding/hex: invalid byte: U+0067 'g'"},
> {"0\x01", "encoding/hex: invalid byte: U+0001"},
> }
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
Issue 46880043: code review 46880043: encoding/hex: add Decode error test case
(Closed)
Created 11 years, 6 months ago by shawnps
Modified 11 years, 6 months ago
Reviewers:
Base URL:
Comments: 0