Add chrome-specific atom for checking whether an element is clickable at a

Add chrome-specific atom for checking whether an element is clickable at a
certain point. This will hopefully help in reducing number of false reports
of broken clicking functionality.

[jleyba, 2011-07-02 00:10:27]

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/atoms.js
File javascript/chrome-driver/atoms.js (right):

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/atoms.j...
javascript/chrome-driver/atoms.js:193: * @return {{clickable:boolean,
message:string}} Object containing a boolean
s/message:string/message:string=/ (= for optional attributes)

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/atoms.j...
javascript/chrome-driver/atoms.js:205: var elemAtPoint =
document.elementFromPoint(coord.x, coord.y);
s/document/elem.ownerDocument/

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/atoms.j...
javascript/chrome-driver/atoms.js:215: while (iter != null) {
while (iter) {

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/atoms.j...
javascript/chrome-driver/atoms.js:221: elemAtPoint.outerHTML);
If you're logging this message, elemAtPoint.outerHTML could be quite noisy.  How
about:  elemAtPoint.outerHTML.replace(elemAtPoint.innerHTML, '...')

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/test/is...
File javascript/chrome-driver/test/is_element_clickable_test.html (right):

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/test/is...
javascript/chrome-driver/test/is_element_clickable_test.html:32: return
webdriver.chrome.isElementClickable(elem, coord).clickable;
Call isElementClickable once and store it in a tmp

[kkania1, 2011-07-04 16:39:22]

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/atoms.js
File javascript/chrome-driver/atoms.js (right):

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/atoms.j...
javascript/chrome-driver/atoms.js:193: * @return {{clickable:boolean,
message:string}} Object containing a boolean
On 2011/07/02 00:10:27, jleyba wrote:
> s/message:string/message:string=/ (= for optional attributes)

Done.

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/atoms.j...
javascript/chrome-driver/atoms.js:205: var elemAtPoint =
document.elementFromPoint(coord.x, coord.y);
On 2011/07/02 00:10:27, jleyba wrote:
> s/document/elem.ownerDocument/

Done.

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/atoms.j...
javascript/chrome-driver/atoms.js:215: while (iter != null) {
On 2011/07/02 00:10:27, jleyba wrote:
> while (iter) {

Done.

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/atoms.j...
javascript/chrome-driver/atoms.js:221: elemAtPoint.outerHTML);
On 2011/07/02 00:10:27, jleyba wrote:
> If you're logging this message, elemAtPoint.outerHTML could be quite noisy. 
How
> about:  elemAtPoint.outerHTML.replace(elemAtPoint.innerHTML, '...')

Done. Used it below too.

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/test/is...
File javascript/chrome-driver/test/is_element_clickable_test.html (right):

http://codereview.appspot.com/4671042/diff/1/javascript/chrome-driver/test/is...
javascript/chrome-driver/test/is_element_clickable_test.html:32: return
webdriver.chrome.isElementClickable(elem, coord).clickable;
On 2011/07/02 00:10:27, jleyba wrote:
> Call isElementClickable once and store it in a tmp

Done.

[kkania1, 2011-07-20 23:09:46]

switching reviewers to Eran

[Eran, 2011-07-21 16:33:50]

LGTM

http://codereview.appspot.com/4671042/diff/5001/javascript/chrome-driver/atom...
File javascript/chrome-driver/atoms.js (right):

http://codereview.appspot.com/4671042/diff/5001/javascript/chrome-driver/atom...
javascript/chrome-driver/atoms.js:213: }
Nitpick: name iter so it indicates we're iterating over parents of the element
that was found at that point.

[kkania1, 2011-07-21 18:39:13]

fixed comments; can you commit it for me?

http://codereview.appspot.com/4671042/diff/5001/javascript/chrome-driver/atom...
File javascript/chrome-driver/atoms.js (right):

http://codereview.appspot.com/4671042/diff/5001/javascript/chrome-driver/atom...
javascript/chrome-driver/atoms.js:213: }
On 2011/07/21 16:33:50, Eran wrote:
> Nitpick: name iter so it indicates we're iterating over parents of the element
> that was found at that point.

Done.

[kkania1, 2011-07-25 14:30:53]

ping?

[Eran, 2011-07-26 14:42:59]

Committed in r13091.