Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(338)

Issue 4668045: Fixes error for tuplet bracket direction calculation when tuplets contain rests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by MikeSol
Modified:
2 years, 8 months ago
Reviewers:
mike, Keith, james.lowe, Neil Puttock, J_lowe, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fixes error for tuplet bracket direction calculation when tuplets contain rests.

Patch Set 1 #

Patch Set 2 : Adds regtest. #

Patch Set 3 : Better tweaking of automatic tuplet positioning. #

Patch Set 4 : Adds TupletBracket to direction-polyphonic-grobs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -2 lines) Patch
A input/regression/tuplet-bracket-direction.ly View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M lily/tuplet-bracket.cc View 1 2 1 chunk +26 lines, -1 line 0 comments Download
M scm/music-functions.scm View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14
MikeSol
Cheers, MS
2 years, 9 months ago #1
James.Lowe_datacore.com
Mike, ________________________________________ From: lilypond-devel-bounces+james.lowe=datacore.com@gnu.org [lilypond-devel-bounces+james.lowe=datacore.com@gnu.org] on behalf of mtsolo@gmail.com [mtsolo@gmail.com] Sent: 29 June 2011 12:25 ...
2 years, 9 months ago #2
hanwenn
test missing. On Wed, Jun 29, 2011 at 8:25 AM, <mtsolo@gmail.com> wrote: > Reviewers: , ...
2 years, 9 months ago #3
Graham Percival
On Wed, Jun 29, 2011 at 12:35:35PM +0000, James Lowe wrote: > > Fixes error ...
2 years, 9 months ago #4
J_lowe
Pass all reg tests. However, I note that in the tuplet_rest.ly file i) the tuplet ...
2 years, 9 months ago #5
MikeSol
Ah, the old coup de regtest. Gets me every time... New patch set uploaded. Cheers, ...
2 years, 9 months ago #6
mike_apollinemike.com
On Jun 29, 2011, at 3:25 PM, pkx166h@gmail.com wrote: > Pass all reg tests. > ...
2 years, 9 months ago #7
J_lowe
On 2011/06/29 13:20:57, graham_percival-music.ca wrote: > On Wed, Jun 29, 2011 at 12:35:35PM +0000, James ...
2 years, 9 months ago #8
J_lowe
On 2011/06/29 16:32:33, mike_apollinemike.com wrote: > On Jun 29, 2011, at 3:25 PM, mailto:pkx166h@gmail.com wrote: ...
2 years, 9 months ago #9
MikeSol
On 2011/06/30 00:13:20, J_lowe wrote: > On 2011/06/29 16:32:33, http://mike_apollinemike.com wrote: > > On Jun ...
2 years, 9 months ago #10
Keith
Looks good and works good for me. On 2011/06/29 16:32:33, mike_apollinemike.com wrote: > > The ...
2 years, 9 months ago #11
Neil Puttock
Hi Mike, This looks fine apart from the following change: \relative c'' { \voiceTwo \times ...
2 years, 9 months ago #12
mike_apollinemike.com
On Jul 18, 2011, at 11:45 PM, n.puttock@gmail.com wrote: > Hi Mike, > > This ...
2 years, 9 months ago #13
MikeSol
2 years, 8 months ago #14
Pushed as eed6f105c0b478572ec2b8fa93e1f96c0c5869ba.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5