Issue 4664043: resolve all checkstyle errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4664043: resolve all checkstyle errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by yanivi

Modified:
15 years, 4 months ago

Reviewers:
jasonhall

Visibility:
Public.

Patch Set 2 : minor whitespace fix #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -20 lines)			Patch
M	checkstyle.xml	View		3 chunks	+4 lines, -12 lines	0 comments	Download
A	checkstyle-suppressions.xml	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	google-api-client-extensions-android2/.settings/org.eclipse.jdt.ui.prefs	View		2 chunks	+54 lines, -2 lines	0 comments	Download
M	google-api-client-extensions/.settings/org.eclipse.jdt.ui.prefs	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/.settings/org.eclipse.jdt.ui.prefs	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/json/AbstractJsonFeedParser.java	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/json/JsonFeedParser.java	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/json/JsonMultiKindFeedParser.java	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/xml/atom/MultiKindFeedParser.java	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	pom.xml	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jasonhall

LGTM http://codereview.appspot.com/4664043/diff/1/checkstyle-suppressions.xml File checkstyle-suppressions.xml (right): http://codereview.appspot.com/4664043/diff/1/checkstyle-suppressions.xml#newcode6 checkstyle-suppressions.xml:6: <suppressions> Can we remove this file until we ...

15 years, 4 months ago (2011-06-23 20:23:56 UTC) #2

yanivi

15 years, 4 months ago (2011-06-23 20:31:10 UTC) #3

http://codereview.appspot.com/4664043/diff/1/checkstyle-suppressions.xml
File checkstyle-suppressions.xml (right):

http://codereview.appspot.com/4664043/diff/1/checkstyle-suppressions.xml#newc...
checkstyle-suppressions.xml:6: <suppressions>
On 2011/06/23 20:23:56, jasonhall wrote:
> Can we remove this file until we have some suppressions to add to it?

I understand why you are asking this, but I'd just like to make it really easy
to add a suppression if necessary without having to mess with the pom.xml file.

http://codereview.appspot.com/4664043/diff/1/google-api-client/src/main/java/...
File
google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java
(right):

http://codereview.appspot.com/4664043/diff/1/google-api-client/src/main/java/...
google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java:129:

On 2011/06/23 20:23:56, jasonhall wrote:
> Is this empty line necessary?

Done.

Expand All Messages | Collapse All Messages