Issue 4661044: Added (optional) opaque support to DigestAuth

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4661044: Added (optional) opaque support to DigestAuth

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by daniellindsley

Modified:
12 years, 10 months ago

Reviewers:
httplib2-dev, jcgregorio

CC:
daniel_toastdriven.com

Visibility:
Public.

Description

The existing implementation will cause servers that send the opaque to reject authentication if it's not sent back. This patch fixes that. Python 2 & 3 support present, plus tests. Fork at https://bitbucket.org/toastdriven/httplib2/. This closes http://code.google.com/p/httplib2/issues/detail?id=55 as well.

Patch Set 1 #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -0 lines)			Patch
M	python2/httplib2/__init__.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	python2/httplib2test.py	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	python3/httplib2/__init__.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	python3/httplib2test.py	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jcgregorio

LGTM Committed at http://code.google.com/p/httplib2/source/detail?r=fb4aa0dd7fe3a9c9ecfcbf3b514bcbe5276c0ff0

12 years, 10 months ago (2011-06-22 20:56:40 UTC) #1

And thanks for the patch!

Expand All Messages | Collapse All Messages