Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2755)

Issue 4651: Mercurial support for upload.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 2 months ago by Antoine Pitrou
Modified:
15 years, 3 months ago
Visibility:
Public.

Description

This patch implements Mercurial support for upload.py. It can be run from the base repository directory or from any subdirectory of it (in which case it will only consider files inside the subtree). This very patch was uploaded using the modified version.

Patch Set 1 #

Patch Set 2 : New attempt - adding a newline of the end of diff to see if it solves the problem #

Patch Set 3 : New patch using output of "hg parent" instead of "tip" #

Patch Set 4 : Updated patch against trunk, correcting all remarks and implementing support for --rev #

Patch Set 5 : New patch with handling of binary and image files #

Patch Set 6 : Fix bug with removed files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -9 lines) Patch
M static/upload.py View 1 2 3 4 5 5 chunks +119 lines, -9 lines 0 comments Download

Messages

Total messages: 20
Antoine Pitrou
Ouch. The first time I tried to display the side-by-side diff, it worked. But after ...
16 years, 2 months ago (2008-09-05 19:25:35 UTC) #1
Antoine Pitrou
It seems to be working better... http://codereview.appspot.com/4651/diff/202/4 File static/upload.py (right): http://codereview.appspot.com/4651/diff/202/4#newcode792 Line 792: self.base_rev = ...
16 years, 2 months ago (2008-09-05 19:42:17 UTC) #2
ondrej.certik
On 2008/09/05 19:42:17, Antoine Pitrou wrote: > It seems to be working better... > > ...
16 years, 2 months ago (2008-09-05 19:44:48 UTC) #3
Andi Albrecht
http://codereview.appspot.com/4651/diff/202/4 File static/upload.py (right): http://codereview.appspot.com/4651/diff/202/4#newcode792 Line 792: self.base_rev = "tip" On 2008/09/05 19:42:17, Antoine Pitrou ...
16 years, 2 months ago (2008-09-05 20:06:41 UTC) #4
Antoine Pitrou
Hi, (I just tested the patch under Windows. It seems to work there too) On ...
16 years, 2 months ago (2008-09-05 20:20:09 UTC) #5
Andi Albrecht
On 2008/09/05 20:20:09, Antoine Pitrou wrote: > Hi, > > (I just tested the patch ...
16 years, 2 months ago (2008-09-06 20:09:34 UTC) #6
Andi Albrecht
http://codereview.appspot.com/4651/diff/205/9 File static/upload.py (right): http://codereview.appspot.com/4651/diff/205/9#newcode792 Line 792: self.base_rev = RunShell(["hg", "parent", "-q"]).split(':')[1].strip() hm, maybe I've ...
16 years, 2 months ago (2008-09-07 17:21:30 UTC) #7
Antoine Pitrou
On 2008/09/07 17:21:30, andi.albrecht wrote: > hm, maybe I've did something wrong (I'm no hg ...
16 years, 2 months ago (2008-09-07 18:10:27 UTC) #8
GvR
I'll let others review this. I think it's a good idea though!
16 years, 2 months ago (2008-09-16 17:51:47 UTC) #9
Andi Albrecht
Antoine, the --rev option is now committed.
16 years, 2 months ago (2008-09-17 08:12:14 UTC) #10
Antoine Pitrou
On 2008/09/17 08:12:14, andi.albrecht wrote: > Antoine, the --rev option is now committed. This new ...
16 years, 1 month ago (2008-09-26 22:55:03 UTC) #11
Andi Albrecht
Looks good for me, but I'm no experienced Mercurial user... ;-) @Ondrej: Do you have ...
16 years, 1 month ago (2008-09-28 07:09:18 UTC) #12
Antoine Pitrou
On 2008/09/28 07:09:18, andi.albrecht wrote: > > @John: AFAICT the Mercurial implementation always uses is_binary=False ...
16 years, 1 month ago (2008-09-30 11:27:45 UTC) #13
Antoine Pitrou
Attached a new patch which adds handling of binary and image files, and uses the ...
16 years, 1 month ago (2008-10-01 22:07:19 UTC) #14
Andi Albrecht
Mostly looks good to me. I've had a problem with removed files and --rev option, ...
16 years, 1 month ago (2008-10-03 07:56:52 UTC) #15
Antoine Pitrou
Uploaded new patch to fix the problem with removed files. Please review :) http://codereview.appspot.com/4651/diff/1402/1601 File ...
16 years, 1 month ago (2008-10-03 17:26:44 UTC) #16
Antoine Pitrou
On second thought, it might be better to separate stdout from stderr in RunShell() (at ...
16 years, 1 month ago (2008-10-03 17:47:08 UTC) #17
Andi Albrecht
Committed r339. Thanks Antoine!! --> http://codereview.appspot.com/static/upload.py
16 years, 1 month ago (2008-10-03 22:21:58 UTC) #18
Andi Albrecht
On 2008/10/03 22:21:58, andi.albrecht wrote: > Committed r339. Thanks Antoine!! > --> http://codereview.appspot.com/static/upload.py Antoine, you ...
16 years, 1 month ago (2008-10-08 04:52:45 UTC) #19
Antoine Pitrou
16 years, 1 month ago (2008-10-08 15:10:36 UTC) #20
On 2008/10/08 04:52:45, andi.albrecht wrote:
> On 2008/10/03 22:21:58, andi.albrecht wrote:
> > Committed r339. Thanks Antoine!!
> > --> http://codereview.appspot.com/static/upload.py
> 
> Antoine, you can close this issue now. Thanks again!

Oops, indeed. Sorry!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b