Add --rev option to specify revision to diff against for DVCS

[Andi Albrecht, 2008-09-07 17:22:26]

DVCS require a more specific definition of the branch or revision to diff
against than Subversion.

This patch adds a command line option for this purpose and propagtes it through
to the VCS implementations.

[Antoine Pitrou, 2008-09-07 18:12:23]

http://codereview.appspot.com/4842/diff/202/3
File static/upload.py (right):

http://codereview.appspot.com/4842/diff/202/3#newcode412
Line 412: group.add_option("--rev", action="store", dest="revision",
Hmm, I first thought it would use "-r" as a shortcut but I see it's already
taken by the "reviewers" option. So, I guess "--rev" is short enough.

(otherwise it could be replaced with "-b"/"--base" or "-b"/"--branch" or even
"-b"/"--base-rev")

[Andi Albrecht, 2008-09-15 04:05:17]

On 2008/09/07 18:12:23, Antoine Pitrou wrote:
> http://codereview.appspot.com/4842/diff/202/3
> File static/upload.py (right):
> 
> http://codereview.appspot.com/4842/diff/202/3#newcode412
> Line 412: group.add_option("--rev", action="store", dest="revision",
> Hmm, I first thought it would use "-r" as a shortcut but I see it's already
> taken by the "reviewers" option. So, I guess "--rev" is short enough.
> 
> (otherwise it could be replaced with "-b"/"--base" or "-b"/"--branch" or even
> "-b"/"--base-rev")

I'd prefer "--rev". It's short and can be used to specify a revision range too
(e.g. in the Subversion patch).

Any additional comments on this? I'd like to get this in to go ahead with
Antoine's patch for adding Mercurial support.

[GvR, 2008-09-16 17:36:59]

I'm okay with this going in.

http://codereview.appspot.com/4842/diff/202/3
File static/upload.py (right):

http://codereview.appspot.com/4842/diff/202/3#newcode412
Line 412: group.add_option("--rev", action="store", dest="revision",
On 2008/09/07 18:12:24, Antoine Pitrou wrote:
> Hmm, I first thought it would use "-r" as a shortcut but I see it's already
> taken by the "reviewers" option. So, I guess "--rev" is short enough.
> 
> (otherwise it could be replaced with "-b"/"--base" or "-b"/"--branch" or even
> "-b"/"--base-rev")
> 

Note, you can call it --revision but type --rev; the optparser parser is smart
enough to allow unambiguous abbreviations.

[Andi Albrecht, 2008-09-17 08:01:51]

On 2008/09/16 17:36:59, GvR wrote:
> I'm okay with this going in.
> 
> http://codereview.appspot.com/4842/diff/202/3
> File static/upload.py (right):
> 
> http://codereview.appspot.com/4842/diff/202/3#newcode412
> Line 412: group.add_option("--rev", action="store", dest="revision",
> On 2008/09/07 18:12:24, Antoine Pitrou wrote:
> > Hmm, I first thought it would use "-r" as a shortcut but I see it's already
> > taken by the "reviewers" option. So, I guess "--rev" is short enough.
> > 
> > (otherwise it could be replaced with "-b"/"--base" or "-b"/"--branch" or
even
> > "-b"/"--base-rev")
> > 
> 
> Note, you can call it --revision but type --rev; the optparser parser is smart
> enough to allow unambiguous abbreviations.

Unfortunately it's ambigous, we already have the --reviewers option ;-)
Committed r316.