Comments on changes regarding what they are doing. https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs File Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs (right): https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs#newcode214 Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs:214: protected ...
10 years, 8 months ago
(2014-01-06 17:06:46 UTC)
#2
10 years, 8 months ago
(2014-01-07 00:49:20 UTC)
#4
LGTM
https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/Apis/Requ...
File Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs (right):
https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/Apis/Requ...
Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs:214: protected override
Task<HttpResponseMessage> SendAsyncCore(HttpRequestMessage request,
ack.
On 2014/01/06 21:43:13, peleyal wrote:
> there isn't a call to await so declaring the method as async is unnecessary.
> This method will be called as part of HttpClient messaging so it will be
async.
>
> On 2014/01/06 17:06:47, class wrote:
> > Will this still execute asynchronously?
>
https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/GoogleApi...
File Src/GoogleApis.Tests/GoogleApis.Tests.csproj (left):
https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/GoogleApi...
Src/GoogleApis.Tests/GoogleApis.Tests.csproj:54:
<DocumentationFile>bin\Release\Google.Apis.Tests.xml</DocumentationFile>
Ack, I don't see any need to generate these docs.
On 2014/01/06 21:43:13, peleyal wrote:
> I think that there is no need to generate xml doc for tests. Do you think
> otherwise?
> On 2014/01/06 17:06:47, class wrote:
> > This looks like it removes the test and then adds an empty one, is that
right?
>
Issue 46460043: Issue 432: Batch request with null callback throws exception
(Closed)
Created 10 years, 8 months ago by peleyal
Modified 10 years, 7 months ago
Reviewers: class
Base URL: https://google-api-dotnet-client.googlecode.com/hg/
Comments: 6