Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(191)

Issue 46460043: Issue 432: Batch request with null callback throws exception (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by peleyal
Modified:
5 years, 4 months ago
Reviewers:
class
CC:
google-api-dotnet-client_googlegroups.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 432: Batch request with null callback throws exception

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs View 3 chunks +33 lines, -2 lines 3 comments Download
M Src/GoogleApis.Tests/GoogleApis.Tests.csproj View 1 chunk +2 lines, -1 line 3 comments Download
M Src/GoogleApis/Apis/Requests/BatchRequest.cs View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
peleyal
small code review - fix for batch request. Thanks, Eyal
5 years, 4 months ago (2013-12-30 11:08:03 UTC) #1
class
Comments on changes regarding what they are doing. https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs File Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs (right): https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs#newcode214 Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs:214: protected ...
5 years, 4 months ago (2014-01-06 17:06:46 UTC) #2
peleyal
https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs File Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs (right): https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs#newcode214 Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs:214: protected override Task<HttpResponseMessage> SendAsyncCore(HttpRequestMessage request, there isn't a call ...
5 years, 4 months ago (2014-01-06 21:43:12 UTC) #3
class
5 years, 4 months ago (2014-01-07 00:49:20 UTC) #4
LGTM

https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/Apis/Requ...
File Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs (right):

https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/Apis/Requ...
Src/GoogleApis.Tests/Apis/Requests/BatchRequestTest.cs:214: protected override
Task<HttpResponseMessage> SendAsyncCore(HttpRequestMessage request,
ack.

On 2014/01/06 21:43:13, peleyal wrote:
> there isn't a call to await so declaring the method as async is unnecessary.
> This method will be called as part of HttpClient messaging so it will be
async.
> 
> On 2014/01/06 17:06:47, class wrote:
> > Will this still execute asynchronously?
>

https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/GoogleApi...
File Src/GoogleApis.Tests/GoogleApis.Tests.csproj (left):

https://codereview.appspot.com/46460043/diff/1/Src/GoogleApis.Tests/GoogleApi...
Src/GoogleApis.Tests/GoogleApis.Tests.csproj:54:
<DocumentationFile>bin\Release\Google.Apis.Tests.xml</DocumentationFile>
Ack, I don't see any need to generate these docs.
On 2014/01/06 21:43:13, peleyal wrote:
> I think that there is no need to generate xml doc for tests. Do you think
> otherwise?
> On 2014/01/06 17:06:47, class wrote:
> > This looks like it removes the test and then adds an empty one, is that
right?
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b