Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3289)

Issue 4645056: Action + Selection Feature patch

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Matt H.
Modified:
12 years, 9 months ago
Reviewers:
Paul Lindner, dev, WoodstaE
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk
Visibility:
Public.

Description

This patch adds the Action and Selection feature implementations for Shindig as specified here: http://docs.opensocial.org/display/OSD/Declarative+Actions+Contributions+and+Selection There are some small changes to the spec and I have attached a patch for those. Unfortunately all patches need to share the same base for this tool so the diff view won't work here.

Patch Set 1 : Action + Selection feature patch #

Patch Set 2 : Demo container for Actions+Selection #

Patch Set 3 : Updated OS 2.0 spec patch #

Patch Set 4 : Action + Selection feature patch (post gjslint) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1527 lines, -0 lines) Patch
features/pom.xml View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
features/src/main/javascript/features/actions/actions.js View 1 2 3 1 chunk +212 lines, -0 lines 0 comments Download
features/src/main/javascript/features/actions/actions_container.js View 1 2 3 1 chunk +734 lines, -0 lines 0 comments Download
features/src/main/javascript/features/actions/feature.xml View 2 3 1 chunk +20 lines, -0 lines 0 comments Download
features/src/main/javascript/features/actions/taming.js View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
features/src/main/javascript/features/features.txt View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
features/src/main/javascript/features/selection/feature.xml View 2 3 1 chunk +36 lines, -0 lines 0 comments Download
features/src/main/javascript/features/selection/selection.js View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
features/src/main/javascript/features/selection/selection_container.js View 1 2 3 1 chunk +77 lines, -0 lines 0 comments Download
features/src/main/javascript/features/selection/taming.js View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
features/src/test/javascript/features/actions/actions_test.js View 2 3 1 chunk +224 lines, -0 lines 0 comments Download
features/src/test/javascript/features/selection/selection_test.js View 2 3 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Matt H.
12 years, 10 months ago (2011-06-23 15:06:39 UTC) #1
Matt H.
On 2011/06/23 15:06:39, Matt H. wrote: I will post an additional patch set soon that ...
12 years, 10 months ago (2011-06-23 15:23:58 UTC) #2
Matt H.
Patches for this issue have been posted. Please review. Thanks.
12 years, 10 months ago (2011-06-23 21:16:32 UTC) #3
Matt H.
I have updated the main feature patch after running gjslint. You can ignore patch set ...
12 years, 9 months ago (2011-07-11 19:18:07 UTC) #4
WoodstaE
Patch applied to Shindig trunk. Thanks, Matt.
12 years, 9 months ago (2011-07-14 19:18:08 UTC) #5
WoodstaE
12 years, 9 months ago (2011-07-14 19:18:38 UTC) #6
On 2011/07/14 19:18:08, WoodstaE wrote:
> Patch applied to Shindig trunk.  Thanks, Matt.

To clarify, patch sets 2 & 4 were committed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b