Issue 46440043: Issue 422: Back button doesn't work on WP Auth login page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 46440043: Issue 422: Back button doesn't work on WP Auth login page (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by peleyal

Modified:
11 years ago

Reviewers:
class

CC:
google-api-dotnet-client_googlegroups.com

Base URL:
https://google-api-dotnet-client.googlecode.com/hg/

Visibility:
Public.

More Reviews

Description

Issue 422: Back button doesn't work on WP Auth login page

Patch Set 3 : minor #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
	M	Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs	View	1 2	3 chunks	+26 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

peleyal

Small fix for Issues 422 and 431 https://code.google.com/p/google-api-dotnet-client/issues/detail?id=422 https://code.google.com/p/google-api-dotnet-client/issues/detail?id=431

11 years ago (2014-01-09 21:15:45 UTC) #1

class

LGTM. Some optional nits for comments. https://codereview.appspot.com/46440043/diff/20001/Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs File Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs (right): https://codereview.appspot.com/46440043/diff/20001/Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs#newcode73 Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs:73: // See https://code.google.com/p/google-api-dotnet-client/issues/detail?id=431. ...

11 years ago (2014-01-13 19:10:29 UTC) #2

peleyal

11 years ago (2014-01-14 23:33:13 UTC) #3

Message was sent while issue was closed.

https://codereview.appspot.com/46440043/diff/20001/Src/GoogleApis.Auth.WP/OAu...
File Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs
(right):

https://codereview.appspot.com/46440043/diff/20001/Src/GoogleApis.Auth.WP/OAu...
Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs:73: //
See https://code.google.com/p/google-api-dotnet-client/issues/detail?id=431. if
we set a null
On 2014/01/13 19:10:29, class wrote:
> More concisely written as:
> 
> // See
https://code.google.com/p/google-api-dotnet-client/issues/detail?id=431. 
> // If we encounter a null exception, cancel the task because the WP app
crashed.

Done.

https://codereview.appspot.com/46440043/diff/20001/Src/GoogleApis.Auth.WP/OAu...
Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs:103:
void RootPage_BackKeyPress(object sender, System.ComponentModel.CancelEventArgs
e)
On 2014/01/13 19:10:29, class wrote:
> Consider adding a <summary> comment, e.g:
> 
> <summary>Callback handler for when the user backs out from the root
> page.</summary>

Done.

Expand All Messages | Collapse All Messages