Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(220)

Issue 46440043: Issue 422: Back button doesn't work on WP Auth login page (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by peleyal
Modified:
5 years, 4 months ago
Reviewers:
class
CC:
google-api-dotnet-client_googlegroups.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 422: Back button doesn't work on WP Auth login page

Patch Set 1 #

Patch Set 2 : minor #

Total comments: 4

Patch Set 3 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs View 1 2 3 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 3
peleyal
Small fix for Issues 422 and 431 https://code.google.com/p/google-api-dotnet-client/issues/detail?id=422 https://code.google.com/p/google-api-dotnet-client/issues/detail?id=431
5 years, 4 months ago (2014-01-09 21:15:45 UTC) #1
class
LGTM. Some optional nits for comments. https://codereview.appspot.com/46440043/diff/20001/Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs File Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs (right): https://codereview.appspot.com/46440043/diff/20001/Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs#newcode73 Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs:73: // See https://code.google.com/p/google-api-dotnet-client/issues/detail?id=431. ...
5 years, 4 months ago (2014-01-13 19:10:29 UTC) #2
peleyal
5 years, 4 months ago (2014-01-14 23:33:13 UTC) #3
Message was sent while issue was closed.
https://codereview.appspot.com/46440043/diff/20001/Src/GoogleApis.Auth.WP/OAu...
File Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs
(right):

https://codereview.appspot.com/46440043/diff/20001/Src/GoogleApis.Auth.WP/OAu...
Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs:73: //
See https://code.google.com/p/google-api-dotnet-client/issues/detail?id=431. if
we set a null
On 2014/01/13 19:10:29, class wrote:
> More concisely written as:
> 
> // See
https://code.google.com/p/google-api-dotnet-client/issues/detail?id=431. 
> // If we encounter a null exception, cancel the task because the WP app
crashed.

Done.

https://codereview.appspot.com/46440043/diff/20001/Src/GoogleApis.Auth.WP/OAu...
Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs:103:
void RootPage_BackKeyPress(object sender, System.ComponentModel.CancelEventArgs
e)
On 2014/01/13 19:10:29, class wrote:
> Consider adding a <summary> comment, e.g:
> 
> <summary>Callback handler for when the user backs out from the root
> page.</summary>

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b