Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1791)

Issue 4641085: Sets spanner length as a spanner property. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 12 months ago by MikeSol
Modified:
7 years, 11 months ago
Reviewers:
mike, Neil Puttock, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Sets spanner length as a spanner property.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adds definition for hyphen length #

Patch Set 3 : Adds hyphen-length definition. #

Patch Set 4 : Changes name of property to spanner-length. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M lily/spanner.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8
MikeSol
Hey all, This patch simplifies a lot of code duping I'm doing to get spanner ...
7 years, 12 months ago (2011-06-30 14:21:00 UTC) #1
MikeSol
On 2011/06/30 14:21:00, MikeSol wrote: > Hey all, > > This patch simplifies a lot ...
7 years, 12 months ago (2011-06-30 14:32:36 UTC) #2
Neil Puttock
On 2011/06/30 14:32:36, MikeSol wrote: > On 2011/06/30 14:21:00, MikeSol wrote: > > Hey all, ...
7 years, 12 months ago (2011-06-30 14:52:04 UTC) #3
Neil Puttock
http://codereview.appspot.com/4641085/diff/1/lily/spanner.cc File lily/spanner.cc (right): http://codereview.appspot.com/4641085/diff/1/lily/spanner.cc#newcode551 lily/spanner.cc:551: "length " this conflicts with the current usage for ...
7 years, 12 months ago (2011-06-30 14:56:25 UTC) #4
MikeSol
On 2011/06/30 14:56:25, Neil Puttock wrote: > http://codereview.appspot.com/4641085/diff/1/lily/spanner.cc > File lily/spanner.cc (right): > > http://codereview.appspot.com/4641085/diff/1/lily/spanner.cc#newcode551 ...
7 years, 12 months ago (2011-06-30 15:15:09 UTC) #5
hanwenn
On Thu, Jun 30, 2011 at 11:21 AM, <mtsolo@gmail.com> wrote: > Reviewers: , > > ...
7 years, 12 months ago (2011-06-30 15:20:23 UTC) #6
mike_apollinemike.com
On Jun 30, 2011, at 5:20 PM, Han-Wen Nienhuys wrote: > On Thu, Jun 30, ...
7 years, 12 months ago (2011-06-30 15:38:46 UTC) #7
Colin Campbell
7 years, 12 months ago (2011-07-01 02:33:55 UTC) #8
Addewd as issue 1729
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b