Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(143)

Issue 4639068: code review 4639068: http: buffer Request.Write (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by bradfitz
Modified:
10 years, 7 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

http: buffer Request.Write Fixes issue 1996

Patch Set 1 #

Patch Set 2 : diff -r c5ff902a17b9 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 3 : diff -r c5ff902a17b9 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 5b8d744d0d63 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -8 lines) Patch
M src/pkg/http/client_test.go View 1 2 2 chunks +46 lines, -0 lines 0 comments Download
M src/pkg/http/request.go View 1 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 7 months ago (2011-06-23 17:26:48 UTC) #1
r
http://codereview.appspot.com/4639068/diff/2001/src/pkg/http/client_test.go File src/pkg/http/client_test.go (right): http://codereview.appspot.com/4639068/diff/2001/src/pkg/http/client_test.go#newcode254 src/pkg/http/client_test.go:254: (*c.count)++ you don't need the parens. ++ is a ...
10 years, 7 months ago (2011-06-24 02:30:36 UTC) #2
bradfitz
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2011-06-24 03:32:33 UTC) #3
r
LGTM
10 years, 7 months ago (2011-06-24 03:35:47 UTC) #4
bradfitz
10 years, 7 months ago (2011-06-24 04:10:56 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=2afae3d73173 ***

http: buffer Request.Write

Fixes issue 1996

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4639068
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b