Code review - Issue 4639068: code review 4639068: http: buffer Request.Writehttps://codereview.appspot.com/2011-06-24T04:10:56+00:00rietveld
Message from unknown
2011-06-23T17:26:34+00:00bradfitzurn:md5:f0f23c878eac0af3592b7f428815af70
Message from unknown
2011-06-23T17:26:45+00:00bradfitzurn:md5:56a06420ad455fe9dad50e9ecf81a373
Message from bradfitz@golang.org
2011-06-23T17:26:48+00:00bradfitzurn:md5:767b92ffef0073451f8988310eb8bab3
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from r@golang.org
2011-06-24T02:30:36+00:00rurn:md5:2e97e59a94a74b8ee952d83fbf481224
http://codereview.appspot.com/4639068/diff/2001/src/pkg/http/client_test.go
File src/pkg/http/client_test.go (right):
http://codereview.appspot.com/4639068/diff/2001/src/pkg/http/client_test.go#newcode254
src/pkg/http/client_test.go:254: (*c.count)++
you don't need the parens. ++ is a statement.
http://codereview.appspot.com/4639068/diff/2001/src/pkg/http/client_test.go#newcode279
src/pkg/http/client_test.go:279: if g, e := writes, 1; g != e {
that's an overly fancy way to say '1'. drop the e var and also the 'want' clause.
http://codereview.appspot.com/4639068/diff/2001/src/pkg/http/client_test.go#newcode288
src/pkg/http/client_test.go:288: if g, e := writes, 1; g != e {
ditto
Message from unknown
2011-06-24T03:32:30+00:00bradfitzurn:md5:b79f6df827881b23e3c0ab427ad63305
Message from bradfitz@golang.org
2011-06-24T03:32:33+00:00bradfitzurn:md5:8bf1ab0678c69ad7ddb7d9675bba0bab
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com),
Please take another look.
Message from r@golang.org
2011-06-24T03:35:47+00:00rurn:md5:63904e81a34c6568599b93c209824d8f
LGTM
Message from unknown
2011-06-24T04:10:49+00:00bradfitzurn:md5:627b43173cd640238001b542e2725a2b
Message from bradfitz@golang.org
2011-06-24T04:10:56+00:00bradfitzurn:md5:ad107c22a61efc1ebae90124269dfc5a
*** Submitted as http://code.google.com/p/go/source/detail?r=2afae3d73173 ***
http: buffer Request.Write
Fixes issue 1996
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4639068