Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3799)

Issue 4631090: embedded experiences patch

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by igor1x
Modified:
12 years, 9 months ago
Reviewers:
Paul Lindner, dev, rbaxter85
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

As described in the specificication here: http://docs.opensocial.org/display/OSD/Embedded+Experiences Please note that this change is dependent on the View Enhancement patch submitted on 06/20 http://codereview.appspot.com/4641058/ The samples can be found in shindig-project/content/samplecontainer/examples/embeddedexperiences/

Patch Set 1 #

Patch Set 2 : fixed a typo in the feature code. #

Patch Set 3 : without tabs this time. #

Total comments: 8

Patch Set 4 : Small change in the cannonical db+unit test modification to reflect that change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1035 lines, -50 lines) Patch
content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml View 2 3 1 chunk +80 lines, -0 lines 0 comments Download
content/samplecontainer/examples/embeddedexperiences/EEContainer.js View 2 3 1 chunk +163 lines, -0 lines 0 comments Download
content/samplecontainer/examples/embeddedexperiences/PhotoList.xml View 2 3 1 chunk +105 lines, -0 lines 0 comments Download
content/samplecontainer/examples/embeddedexperiences/index.html View 2 3 1 chunk +54 lines, -0 lines 0 comments Download
content/sampledata/canonicaldb.json View 2 3 4 chunks +35 lines, -8 lines 0 comments Download
features/pom.xml View 2 3 1 chunk +2 lines, -0 lines 0 comments Download
features/src/main/javascript/features/embeddedexperiences/constant.js View 2 3 1 chunk +40 lines, -0 lines 0 comments Download
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js View 1 2 3 1 chunk +141 lines, -0 lines 0 comments Download
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js View 2 3 1 chunk +57 lines, -0 lines 0 comments Download
features/src/main/javascript/features/embeddedexperiences/feature.xml View 2 3 1 chunk +43 lines, -0 lines 0 comments Download
features/src/main/javascript/features/features.txt View 2 3 1 chunk +1 line, -0 lines 0 comments Download
features/src/test/javascript/features/embeddedexperiences/embedded_experiences_container_test.js View 2 3 1 chunk +113 lines, -0 lines 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomId.xml View 1 2 3 2 chunks +16 lines, -5 lines 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml View 1 2 3 5 chunks +34 lines, -7 lines 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json View 1 2 3 2 chunks +15 lines, -5 lines 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json View 1 2 3 4 chunks +34 lines, -7 lines 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json View 1 2 3 2 chunks +21 lines, -2 lines 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json View 1 2 3 4 chunks +35 lines, -7 lines 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlId.xml View 1 2 3 2 chunks +14 lines, -4 lines 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml View 1 2 3 3 chunks +32 lines, -5 lines 0 comments Download

Messages

Total messages: 6
igor1x
12 years, 10 months ago (2011-07-06 18:06:51 UTC) #1
igor1x
fixed a typo in the feature code.
12 years, 9 months ago (2011-07-07 14:02:08 UTC) #2
igor1x
without tabs this time.
12 years, 9 months ago (2011-07-07 14:10:19 UTC) #3
igor1x
Small change in the cannonical db+unit test modification to reflect that change.
12 years, 9 months ago (2011-07-08 15:09:00 UTC) #4
Paul Lindner
oops, forgot about these comments.. plz ignore if they're no longer relevant. Otherwise looking good, ...
12 years, 9 months ago (2011-07-11 16:05:34 UTC) #5
rbaxter85
12 years, 9 months ago (2011-07-12 01:39:18 UTC) #6
Updated patch and moved code review to the apache code review tool.
https://reviews.apache.org/r/1085/

http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript...
File
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
(right):

http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript...
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:28:
/**
On 2011/07/11 16:05:34, Paul Lindner wrote:
> looks like the indent went to three here.  Can you move it to 2?

Done.

http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript...
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:34:
* @param {function} optional callback function
Actually the function doesn''t even take in a function, so I removed it
completely.
On 2011/07/11 16:05:34, Paul Lindner wrote:
> rename to opt_callback and use {function=} jsdoc.

http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript...
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:53:
* @param {object} renderParams params to augment the rendering.
On 2011/07/11 16:05:34, Paul Lindner wrote:
> uppercase object

Done.

http://codereview.appspot.com/4631090/diff/11001/features/src/main/javascript...
features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js:133:
}
On 2011/07/11 16:05:34, Paul Lindner wrote:
> nit: spacing

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b