Issue 4627078: goprotobuf: updated to `key:"value"` struct tag syntax

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4627078: goprotobuf: updated to `key:"value"` struct tag syntax

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by kevlar

Modified:
12 years, 10 months ago

Reviewers:
rsc1, dsymonds1, r2

Visibility:
Public.

Description

goprotobuf: updated to `key:"value"` struct tag syntax Since I'm working with protocol buffers at tip, pulling 1dd08cd96bc3b32246b14f6cc58f0c53bf393f51 broke goprotobuf. On the off-chance that nobody has done this yet, I figured I'd contribute my patch. There are also a few other miscellaneous things that I apparently fixed, like the goto into blocks, the uintptr size/alignof, and strings.Split. I'm not as confident about these fixes (except the strings.Split, which was done by gofix).

Patch Set 1 #

Patch Set 2 : diff -r fa1080cfc0a4 https://goprotobuf.googlecode.com/hg #

Patch Set 3 : diff -r fa1080cfc0a4 https://goprotobuf.googlecode.com/hg #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+405 lines, -400 lines)			Patch
M	compiler/descriptor/descriptor.pb.go	View	1	20 chunks	+74 lines, -74 lines	0 comments	Download
M	compiler/descriptor/descriptor.pb.golden	View	1	20 chunks	+74 lines, -74 lines	0 comments	Download
M	compiler/generator/generator.go	View	1	4 chunks	+8 lines, -4 lines	0 comments	Download
M	compiler/plugin/plugin.pb.go	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download
M	compiler/plugin/plugin.pb.golden	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download
M	compiler/testdata/test.pb.go.golden	View	1	4 chunks	+13 lines, -13 lines	0 comments	Download
M	proto/lib.go	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	proto/message_set.go	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	proto/properties.go	View	1	7 chunks	+14 lines, -13 lines	0 comments	Download
M	proto/testdata/test.pb.go	View	1	16 chunks	+106 lines, -106 lines	0 comments	Download
M	proto/testdata/test.pb.go.golden	View	1	12 chunks	+90 lines, -90 lines	0 comments	Download
M	proto/text.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download