code review 4627065: godoc: search GOPATH for documentation

godoc: search GOPATH for documentation

[adg, 2011-06-27 07:31:44]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-06-27 14:16:23]

s/GOPATHs/GOPATH/ in CL description

http://codereview.appspot.com/4627065/diff/3001/src/cmd/godoc/main.go
File src/cmd/godoc/main.go (right):

http://codereview.appspot.com/4627065/diff/3001/src/cmd/godoc/main.go#newcode334
src/cmd/godoc/main.go:334: path = filepath.Join(t.SrcDir(), pkg)
This doesn't look right.  Check the output:
I bet it shows a rooted import path instead of
the correct import path.  I think the if here needs
to set both relpath and abspath.

[adg, 2011-06-28 01:00:53]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-07-01 06:16:37]

ping!

On 28 June 2011 11:00,  <adg@golang.org> wrote:
> Hello rsc@golang.org (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
> http://codereview.appspot.com/4627065/
>

[mattn, 2011-07-01 06:23:28]

$ hg clpatch 4627065
codereview issue 4627065 is out of date: patch and recent changes conflict
(b295b8bda20b->add294e751cb)

On 2011/07/01 06:16:37, adg wrote:
> ping!
> 
> On 28 June 2011 11:00,  <mailto:adg@golang.org> wrote:
> > Hello mailto:rsc@golang.org (cc: mailto:golang-dev@googlegroups.com),
> >
> > Please take another look.
> >
> >
> > http://codereview.appspot.com/4627065/
> >

[adg, 2011-07-01 06:28:11]

Done.

[mattn, 2011-07-01 07:02:42]

LGTM

It is working good on my environment.

On 2011/07/01 06:28:11, adg wrote:
> Done.

[rsc, 2011-07-01 14:24:32]

LGTM

http://codereview.appspot.com/4627065/diff/7004/src/cmd/godoc/main.go
File src/cmd/godoc/main.go (right):

http://codereview.appspot.com/4627065/diff/7004/src/cmd/godoc/main.go#newcode339
src/cmd/godoc/main.go:339: } else {
else if !filepath.IsAbs(path)
etc

[adg, 2011-07-02 04:07:13]

*** Submitted as http://code.google.com/p/go/source/detail?r=7ce1c776ff33 ***

godoc: search GOPATH for documentation

R=rsc, mattn.jp
CC=golang-dev
http://codereview.appspot.com/4627065

http://codereview.appspot.com/4627065/diff/7004/src/cmd/godoc/main.go
File src/cmd/godoc/main.go (right):

http://codereview.appspot.com/4627065/diff/7004/src/cmd/godoc/main.go#newcode339
src/cmd/godoc/main.go:339: } else {
On 2011/07/01 14:24:37, rsc wrote:
> else if !filepath.IsAbs(path)
> etc
> 

Done.