src/cmd/godoc/main.go - Issue 4627065: code review 4627065: godoc: search GOPATH for documentation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/godoc/main.go

Issue 4627065: code review 4627065: godoc: search GOPATH for documentation (Closed)

Patch Set: diff -r 338032227e73 https://go.googlecode.com/hg/ Created 13 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/godoc/main.go

===================================================================

--- a/src/cmd/godoc/main.go

+++ b/src/cmd/godoc/main.go

@@ -31,6 +31,7 @@

"flag"

"fmt"

"go/ast"

+ "go/build"

"http"

_ "http/pprof" // to serve /debug/pprof/*

"io"

@@ -332,7 +333,10 @@

}

relpath := path

abspath := path

- if !filepath.IsAbs(path) {

+ if t, pkg, err := build.FindTree(path); err == nil {

+ relpath = pkg

+ abspath = filepath.Join(t.SrcDir(), pkg)

+ } else if !filepath.IsAbs(path) {

abspath = absolutePath(path, pkgHandler.fsRoot)

} else {

relpath = relativeURL(path)

« no previous file with comments | « src/cmd/godoc/godoc.go ('k') | src/cmd/godoc/mapping.go » ('j') | no next file with comments »