Issue 46240043: code review 46240043: runtime: load runtime.goarm as a byte, not a word

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 46240043: code review 46240043: runtime: load runtime.goarm as a byte, not a word (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by dave

Modified:
11 years, 5 months ago

Reviewers:
iant

CC:
iant, minux1, golang-codereviews

Visibility:
Public.

Description

runtime: load runtime.goarm as a byte, not a word Fixes issue 6952. runtime.asminit was incorrectly loading runtime.goarm as a word, not a uint8 which made it subject to alignment issues on arm5 platforms. Alignment aside, this also meant that the top 3 bytes in R11 would have been garbage and could not be assumed to be setting up the FPU reliably.

Patch Set 1 #

Patch Set 2 : diff -r e65ee0eae098 https://code.google.com/p/go #

Patch Set 3 : diff -r e65ee0eae098 https://code.google.com/p/go #

Patch Set 4 : diff -r e65ee0eae098 https://code.google.com/p/go #

Patch Set 5 : diff -r 3ae7a530dd4e https://code.google.com/p/go #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/asm_arm.s	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello iant@golang.org, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2013-12-28 21:16:54 UTC) #1

dave_cheney.net

Thanks for your help figuring this one out Ian. > On 29 Dec 2013, at ...

11 years, 5 months ago (2013-12-29 04:20:02 UTC) #3

dave_cheney.net

11 years, 5 months ago (2013-12-29 04:26:05 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=fecb13086239 ***

runtime: load runtime.goarm as a byte, not a word

Fixes issue 6952.

runtime.asminit was incorrectly loading runtime.goarm as a word, not a uint8
which made it subject to alignment issues on arm5 platforms.

Alignment aside, this also meant that the top 3 bytes in R11 would have been
garbage and could not be assumed to be setting up the FPU reliably.

R=iant, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/46240043

Expand All Messages | Collapse All Messages