Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(284)

Issue 4603056: code review 4603056: build: use awk instead of giant egrep regexp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by rsc
Modified:
13 years, 3 months ago
Reviewers:
peterGo, bradfitz
CC:
r, dsymonds1, golang-dev
Visibility:
Public.

Description

build: use awk instead of giant egrep regexp Avoids buggy version of egrep on some Macs.

Patch Set 1 #

Patch Set 2 : diff -r 3a5f42c956e0 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 3a5f42c956e0 https://go.googlecode.com/hg #

Patch Set 4 : diff -r ba390b1d5e66 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/pkg/deps.bash View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
13 years, 3 months ago (2011-06-15 21:57:06 UTC) #1
dsymonds1
LGTM
13 years, 3 months ago (2011-06-15 22:00:07 UTC) #2
r
LGTM although i'm unsure awk is likely to be more reliable, consistent, and stable. sigh.
13 years, 3 months ago (2011-06-15 22:38:33 UTC) #3
rsc
On Wed, Jun 15, 2011 at 18:38, <r@golang.org> wrote: > LGTM although i'm unsure awk ...
13 years, 3 months ago (2011-06-15 22:56:43 UTC) #4
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=655a4be3968f *** build: use awk instead of giant egrep regexp Avoids buggy ...
13 years, 3 months ago (2011-06-16 04:04:28 UTC) #5
bradfitz
C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at source line 1 context is >>> <<< C:\MinGW\msys\1.0\bin\awk.exe: non-terminated ...
13 years, 3 months ago (2011-06-16 04:34:08 UTC) #6
rsc
try replacing that awk.exe with http://www.cs.princeton.edu/~bwk/btl.mirror/awk95.exe On Thu, Jun 16, 2011 at 00:34, Brad Fitzpatrick ...
13 years, 3 months ago (2011-06-16 04:43:41 UTC) #7
rsc
On Thu, Jun 16, 2011 at 00:50, brainman <alex.brainman@gmail.com> wrote: > On Thursday, 16 June ...
13 years, 3 months ago (2011-06-16 04:53:35 UTC) #8
peterGo
Russ, On 2011/06/16 04:43:41, rsc wrote: > try replacing that awk.exe with > http://www.cs.princeton.edu/%7Ebwk/btl.mirror/awk95.exe Russ, ...
13 years, 3 months ago (2011-06-16 08:16:24 UTC) #9
peterGo
13 years, 3 months ago (2011-06-16 08:35:49 UTC) #10
Russ,

On 2011/06/16 04:43:41, rsc wrote:
> try replacing that awk.exe with
> http://www.cs.princeton.edu/%7Ebwk/btl.mirror/awk95.exe

On Windows, that works for hg id 9d7967223815 (release-branch.r57)
release/release.r57.2.

Peter
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b