code review 4603056: build: use awk instead of giant egrep regexp

build: use awk instead of giant egrep regexp

Avoids buggy version of egrep on some Macs.

[rsc, 2011-06-15 21:57:06]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[dsymonds1, 2011-06-15 22:00:07]

LGTM

[r, 2011-06-15 22:38:33]

LGTM although i'm unsure awk is likely to be more reliable, consistent, and
stable.

sigh.

[rsc, 2011-06-15 22:56:43]

On Wed, Jun 15, 2011 at 18:38,  <r@golang.org> wrote:
> LGTM although i'm unsure awk is likely to be more reliable, consistent,
> and stable.

fair enough but in awk at least i can run N regexps
instead of 1 big regexp.

[rsc, 2011-06-16 04:04:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=655a4be3968f ***

build: use awk instead of giant egrep regexp

Avoids buggy version of egrep on some Macs.

R=r, dsymonds
CC=golang-dev
http://codereview.appspot.com/4603056

[bradfitz, 2011-06-16 04:34:08]

C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
source line 1
 context is
 >>>  <<<
C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
source line 1
 context is
 >>>  <<<
C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
source line 1
 context is
 >>>  <<<
C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
source line 1
 context is
 >>>  <<<
C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
source line 1
 context is
 >>>  <<<
C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
source line 1
 context is
 >>>  <<<
C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
source line 1
 context is
 >>>  <<<
C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
source line 1
 context is
 >>>  <<<
C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
source line 1
 context is
 >>>  <<<
C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
source line 1
 context is
 >>>  <<<
C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
source line 1
 context is
 >>>  <<<


On Wed, Jun 15, 2011 at 9:04 PM, <rsc@golang.org> wrote:

> *** Submitted as
>
http://code.google.com/p/go/**source/detail?r=655a4be3968f<http://code.google...
>
>
> build: use awk instead of giant egrep regexp
>
> Avoids buggy version of egrep on some Macs.
>
> R=r, dsymonds
> CC=golang-dev
>
> http://codereview.appspot.com/**4603056<http://codereview.appspot.com/4603056>
>
>
>
http://codereview.appspot.com/**4603056/<http://codereview.appspot.com/4603056/>
>

[rsc, 2011-06-16 04:43:41]

try replacing that awk.exe with
http://www.cs.princeton.edu/~bwk/btl.mirror/awk95.exe


On Thu, Jun 16, 2011 at 00:34, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
> source line 1
>  context is
>>>>  <<<
> C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
> source line 1
>  context is
>>>>  <<<
> C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
> source line 1
>  context is
>>>>  <<<
> C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
> source line 1
>  context is
>>>>  <<<
> C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
> source line 1
>  context is
>>>>  <<<
> C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
> source line 1
>  context is
>>>>  <<<
> C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
> source line 1
>  context is
>>>>  <<<
> C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
> source line 1
>  context is
>>>>  <<<
> C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
> source line 1
>  context is
>>>>  <<<
> C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
> source line 1
>  context is
>>>>  <<<
> C:\MinGW\msys\1.0\bin\awk.exe: non-terminated regular expression ... at
> source line 1
>  context is
>>>>  <<<
>
> On Wed, Jun 15, 2011 at 9:04 PM, <rsc@golang.org> wrote:
>>
>> *** Submitted as
>> http://code.google.com/p/go/source/detail?r=655a4be3968f ***
>>
>> build: use awk instead of giant egrep regexp
>>
>> Avoids buggy version of egrep on some Macs.
>>
>> R=r, dsymonds
>> CC=golang-dev
>> http://codereview.appspot.com/4603056
>>
>>
>> http://codereview.appspot.com/4603056/
>
>

[rsc, 2011-06-16 04:53:35]

On Thu, Jun 16, 2011 at 00:50, brainman <alex.brainman@gmail.com> wrote:
> On Thursday, 16 June 2011 14:43:36 UTC+10, rsc wrote:
>>
>> try replacing that awk.exe with
>> http://www.cs.princeton.edu/~bwk/btl.mirror/awk95.exe
>
> Not good idea. We'll have people who use Joe's mingw bundle complaining
> tommorrow that build fails.
>
> If you want to change tools, let's make sure that we can give users
> instructions on how to get them first.
>
> Also, when builder fails, we want to be able to reproduce the problem. We
> won't be able to do that, if everyone using different tools.

if the builder is failing we might as well try to find tools that work
so we can tell people how to fix them!

[peterGo, 2011-06-16 08:16:24]

Russ,

On 2011/06/16 04:43:41, rsc wrote:
> try replacing that awk.exe with
> http://www.cs.princeton.edu/%7Ebwk/btl.mirror/awk95.exe

Russ,

On Jun 16, 12:43 am, Russ Cox <r...@golang.org> wrote:
> try replacing that awk.exe
withhttp://www.cs.princeton.edu/~bwk/btl.mirror/awk95.exe

On Windows, this works for hg id 9d7967223815 (release-branch.r57)
release/release.r57.2.

Gawk for Windows
http://gnuwin32.sourceforge.net/packages/gawk.htm

Peter

[peterGo, 2011-06-16 08:35:49]

Russ,

On 2011/06/16 04:43:41, rsc wrote:
> try replacing that awk.exe with
> http://www.cs.princeton.edu/%7Ebwk/btl.mirror/awk95.exe

On Windows, that works for hg id 9d7967223815 (release-branch.r57)
release/release.r57.2.

Peter